ENG-3106: Fix manual task modal content overflowing boundaries#7748
ENG-3106: Fix manual task modal content overflowing boundaries#7748gilluminate merged 2 commits intomainfrom
Conversation
Both AddEditConditionModal and AddManualTaskModal set a minWidth on the modal body that exceeded Ant Design's default 520px modal width, causing form fields to render outside the modal. Replace body minWidth styles with explicit width using the project's MODAL_SIZE constants. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryThis PR fixes a UI overflow bug where form content in the manual task condition and task creation modals visually extended beyond the modal boundaries. The root cause was that both modals applied a The fix replaces body-level Key changes:
Note: Confidence Score: 5/5
Important Files Changed
Reviews (1): Last reviewed commit: "Add changelog for PR #7748" | Re-trigger Greptile |
There was a problem hiding this comment.
Clean, well-scoped fix. The root cause is correctly diagnosed: styles={{ body: { minWidth } }} only expanded the inner body content without widening the modal container, causing content to overflow. Switching to width={MODAL_SIZE.lg} properly sizes the entire modal container.
One minor observation worth noting:
AddManualTaskModal previously declared minWidth: "775px" on the body, while AddEditConditionModal used minWidth: "650px". Both now use MODAL_SIZE.lg (768px). For AddManualTaskModal, that's a slight reduction (775 → 768px) in the effective inner content width (the width prop includes the modal's own padding, so the content area will be a few px narrower than 768). The screenshot in the PR description confirms this looks fine in practice, so this is not a blocker — just worth being aware of if tighter form layouts appear on smaller screens.
No critical issues. The use of the shared MODAL_SIZE constant is the right approach and keeps modal sizing consistent across the codebase.
jpople
left a comment
There was a problem hiding this comment.
Looks good, like the consistency.
Ticket ENG-3106
Description Of Changes
Fix modal content overflowing outside the modal boundaries in the manual task condition and task creation modals. Both
AddEditConditionModalandAddManualTaskModalset aminWidthon the modal body that exceeded Ant Design's default 520px modal width, causing form fields to visually extend beyond the modal container.Replace the
styles={{ body: { minWidth } }}approach with explicitwidthprops using the project's existingMODAL_SIZEconstants frommodal-sizes.ts.Code Changes
width={MODAL_SIZE.lg}(768px) onAddEditConditionModalandAddManualTaskModalinstead of bodyminWidthstyles that overflowed the default 520px modal containerSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated