ENG-2691 Remove unused ecdsa dependency (CVE-2024-23342)#7731
ENG-2691 Remove unused ecdsa dependency (CVE-2024-23342)#7731
Conversation
Leftover from python-jose, replaced by joserfc in ENG-2691. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This is a clean, minimal security fix. No issues found.
Verified:
ecdsais not imported anywhere in the Python codebase (grep confirms zero matches across all*.pyfiles)uv.lockis correctly regenerated, dropping theecdsa==0.19.1package and itssixtransitive dependency reference, reducing the resolved package count from 297 to 296- The changelog entry correctly categorizes this as a
Securitytype with the CVE reference - No other package in the lock file lists
ecdsaas a dependency, confirming it was solely a direct (unused) pin
The removal eliminates CVE-2024-23342 (Minerva timing-attack vulnerability) with zero functional risk. LGTM.
Greptile SummaryThis PR removes the unused
The change is minimal, targeted, and correct. A codebase-wide search confirms Confidence Score: 5/5
Important Files Changed
Reviews (1): Last reviewed commit: "Add changelog for PR #7731" | Re-trigger Greptile |
Ticket ENG-2691 (follow-up)
Description Of Changes
Removes the
ecdsa~=0.19.1direct pin frompyproject.toml. This was a leftover frompython-jose[cryptography]which was replaced byjoserfcin ENG-2691 (#7573). ecdsa is not imported anywhere in fides or fidesplus, and no other package depends on it. Removing it eliminates CVE-2024-23342 (Minerva timing attack, no fix available).Code Changes
ecdsa~=0.19.1frompyproject.tomldependenciesuv.lock(296 packages, down from 297)Steps to Confirm
uv lockresolves without errorsPre-Merge Checklist
CHANGELOG.mdupdated