Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR adds an explicit
Confidence Score: 5/5
Important Files Changed
Reviews (1): Last reviewed commit: "Use ~=5.12.0 pin for ujson upper bound" | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review: ENG-3022 — Bump ujson to ~=5.12.0
This is a clean, minimal security dependency bump. No issues found.
What was verified:
- Version specifier —
~=5.12.0(compatible release:>=5.12.0, <5.13.0) is the correct constraint for a security floor pin, consistent with other dependency pins inpyproject.toml. - Lock file —
uv.lockis properly regenerated with verified hashes for all target platforms (cp313/cp314 across macOS, manylinux, musllinux, win32/win64/arm64). Wheel count and platform coverage are consistent with the previous 5.11.0 entry. - Direct usage — No Python files in the repo import
ujsondirectly, confirming this is purely a transitive dependency (viafastapi[all]) being explicitly floored for security reasons. - Changelog —
changelog/7727-bump-ujson.yamlusestype: Securityand matches the format of other recent security bump entries (e.g., 7718-bump-pyjwt.yaml, 7716-bump-tornado.yaml). - CVE scope — Both CVEs (memory leak DoS via large integers, integer overflow in
dumps) are addressed by 5.12.0 per the upstream release.
LGTM. ✓
adamsachs
left a comment
There was a problem hiding this comment.
👍 (as long as CI passes). this one should be low risk because i believe this is only a dev requirement, doesn't even impact app behavior at all
Ticket ENG-3022
Description Of Changes
Adds an explicit
ujson~=5.12.0floor pin to address CVE-2026-32874 (memory leak DoS via large integers) and CVE-2026-32875 (integer overflow in dumps). ujson is a transitive dependency viafastapi[all]— not imported directly by fides or fidesplus.Code Changes
ujson~=5.12.0pin inpyproject.tomluv.lockSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated