Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR adds an explicit
Confidence Score: 5/5
Important Files Changed
Reviews (1): Last reviewed commit: "Add changelog for PR #7726" | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review: ENG-3021 — Bump pyasn1 to >=0.6.3
Clean, minimal security bump. No logic changes, no new code paths, no migration impact.
Summary
- Correctly adds an explicit
pyasn1floor pin inpyproject.tomlto prevent the CVE-affected 0.6.2 from being resolved as a transitive dep viagoogle-auth/rsa. uv.lockis properly regenerated to 0.6.3.- Changelog entry is present.
Findings
Two minor nits (no blockers):
- Version specifier style (
pyproject.tomlline 130) —>=0.6.3,<0.7.0is functionally correct but differs from the~=style used by adjacent pins. Consider~=0.6.3for consistency. - Changelog wording — "Bumped pyasn1 to 0.6.3" doesn't capture that the pin is a range (
>=0.6.3,<0.7.0). A small clarification would be more precise.
Otherwise LGTM — the fix is appropriately scoped and the lock file reflects the intended resolution.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ticket ENG-3021
Description Of Changes
Adds an explicit
pyasn1~=0.6.3pin to address CVE-2026-30922 (unbounded recursion DoS in ASN.1 decoding). pyasn1 is a transitive dependency viagoogle-authandrsa— not imported directly by fides or fidesplus.Code Changes
pyasn1~=0.6.3pin inpyproject.tomluv.lockSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated