Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR bumps the transitive
No functional code changes, no migrations, and no direct Tornado imports in the Fides codebase. This is a safe, minimal security patch. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: "Fix changelog PR num..." |
There was a problem hiding this comment.
Code Review — Tornado Security Bump
Clean, well-scoped security patch. No issues found.
What was verified:
pyproject.toml: Constraint correctly tightened from~=6.5.2→~=6.5.5. The~=(compatible release) operator means>=6.5.5, <6.6.0, so the patched version is now enforced as the floor. The previous constraint would have permitted installing the vulnerable 6.5.2–6.5.3 range on a clean install. ✓uv.lock: Consistently updated to6.5.5with correct hashes for all platform wheels. The reduction from 11 to 9 wheel entries reflects upstream packaging changes in the tornado 6.5.5 release (dropped oldermanylinux1/manylinux2014i686 wheels) — not a concern. ✓changelog/7716-bump-tornado.yaml: Type correctly set toSecurity, CVE and GHSA references look accurate. ✓
No code logic changes, no migration, no API surface changes. LGTM.
vcruces
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2994
Description Of Changes
Bumps Tornado from 6.5.4 to 6.5.5 to address CVE-2026-31958 (multipart DoS) and GHSA-78cv-mqj4-43f7 (cookie attribute injection). Tornado is not used directly by fides — it's a transitive dependency via Flower (Celery monitoring dashboard).
Code Changes
tornado~=6.5.2→tornado~=6.5.5inpyproject.tomluv.lockSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated