ENG-3015: Add API key auth fields to JiraTicketSchema#7678
Merged
Conversation
Add domain, username, and api_key fields to JiraTicketSchema alongside existing OAuth fields. A model validator enforces mutual exclusivity between OAuth and API key credential groups. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR extends Key changes:
Minor issue found:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 5af2701 |
src/fides/api/schemas/connection_configuration/connection_secrets_jira_ticket.py
Show resolved
Hide resolved
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Include refresh_token and token_expiry in the error message so users can identify which field is causing the conflict. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vcruces
approved these changes
Mar 18, 2026
Contributor
vcruces
left a comment
There was a problem hiding this comment.
Looks good to me, simple change
src/fides/api/schemas/connection_configuration/connection_secrets_jira_ticket.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3015
Description Of Changes
Add dual authentication support to the
jira_ticketconnection type schema. This extendsJiraTicketSchemawith API key fields (domain,username,api_key) alongside existing OAuth 2.0 fields, enabling customers who already have a Jira SaaS connector to reuse their API key credentials for ticket creation without going through a separate OAuth flow.A Pydantic
model_validatorenforces mutual exclusivity — OAuth and API key credentials cannot coexist on the same connection.Code Changes
src/fides/api/schemas/connection_configuration/connection_secrets_jira_ticket.py— Adddomain,username,api_keyfields + mutual exclusivity validator; modernizeOptional[str]→str | Nonetests/service/test_jira_ticket_connection.py— Add tests for API key secrets validation, partial API key, and mixed credential rejectionSteps to Confirm
pytest tests/service/test_jira_ticket_connection.pyPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works