Un-deprecate GET /system/{fides_key}/connection endpoint#7668
Merged
Un-deprecate GET /system/{fides_key}/connection endpoint#7668
Conversation
The get_system_connections endpoint was deprecated in #7432 as part of the system-integration linking refactor, but it serves a distinct access pattern (system → connections) that the new system-links API does not replace. The new endpoints are connection-centric (connection → systems), so there is no efficient way to answer "what connections are linked to this system?" without this endpoint. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile SummaryRemoves the deprecation marker from the
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 8880874 |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
galvana
approved these changes
Mar 16, 2026
adamsachs
added a commit
that referenced
this pull request
Mar 16, 2026
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Un-deprecates the
get_system_connectionsendpoint (GET /system/{fides_key}/connection) that was marked deprecated in #7432 as part of the system-integration linking refactor.The deprecation suggested using
GET /connection(withlinked_systemsin the response) orGET /connection/{connection_key}/system-linksas alternatives. However, neither replaces the system-centric access pattern this endpoint provides:GET /connectionreturns all connections and has nosystem_fides_keyfilter — you'd have to fetch every page and filter client-side.GET /connection/{key}/system-linksgoes the wrong direction (connection → systems, not system → connections).orphaned_from_systemis a boolean filter, not a system-specific one.The
get_system_connectionsendpoint remains the only efficient way to answer "what integrations are linked to this system?" The endpoint was already correctly updated in #7432 to use the newSystemConnectionConfigLinkjoin table, so it works with the new data model — it just shouldn't have been marked deprecated.The other system-scoped write endpoints (
patch_connections,patch_connection_secrets,delete_connection,instantiate_connection_from_template) remain deprecated since they are genuinely replaced by the connection-centric and system-links APIs.Code Changes
src/fides/api/v1/endpoints/system.py- Removedeprecated=Trueflag and deprecation docstring fromget_system_connectionsSteps to Confirm
GET /system/{fides_key}/connectionendpoint no longer shows as deprecated in the OpenAPI docsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works