Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryThis PR adds a new
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 2dd7c8a |
JadeCara
left a comment
There was a problem hiding this comment.
I think this all looks reasonable, there is an existing/known thing with sa.PrimaryKeyConstraint("id") and op.create_index(op.f("ix_encryption_keys_id"), "encryption_keys", ["id"], unique=False)
The PK constraint already creates a unique B-tree index. I am pretty sure the additional non-unique index is redundant. This comes from Alembic autogenerate picking up index=True on FidesBase.id — it's consistent with other tables in the codebase (same pattern everywhere), so it's a known codebase-wide quirk, not specific to this PR. Low priority.
Ticket ENG-2860
Description Of Changes
Adds the
encryption_keysmodel and table (not wired up to anything yet) and updates the encryption implementation plan to better reflect the planned changes.Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works