Upgrade pymssql 2.3.7 -> 2.3.13 to fix MSSQL monitor SIGSEGV#7609
Upgrade pymssql 2.3.7 -> 2.3.13 to fix MSSQL monitor SIGSEGV#7609
Conversation
pymssql 2.3.13 bundles FreeTDS 1.4.26, which fixes known segfault issues in TLS negotiation and connection handling present in FreeTDS 1.3.17 (the version provided by Debian Bookworm's apt repos). Also removes pymssql from no-build-isolation-package so that uv uses the official pre-built wheel (with bundled FreeTDS) rather than compiling from source against the older system FreeTDS headers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis change upgrades the pymssql dependency from 2.3.7 to 2.3.13 to address an MSSQL discovery monitor SIGSEGV issue. The update includes a new changelog entry and removes pymssql from the no-build-isolation-package list in the build configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR upgrades
Confidence Score: 5/5
Important Files Changed
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Ticket ENG-2893
Description Of Changes
Fixes SIGSEGV (signal 11) in the MSSQL discovery monitor Celery worker. The crash occurs during TLS negotiation when pymssql connects to MSSQL servers.
Root cause: pymssql 2.3.7 was being compiled from source (due to
no-build-isolation-packagein pyproject.toml) against the system FreeTDS 1.3.17 (Debian Bookworm). FreeTDS 1.3.17 has known segfault issues in TLS connection handling. The official pymssql wheels bundle a newer FreeTDS (1.4.27) that resolves this, butno-build-isolation-packageforced a source build that linked against the older system library instead.Fix:
no-build-isolation-packageso uv uses the official pre-built wheel with its bundled FreeTDS, rather than compiling from source against the system headersThis is the fides-side change. The companion fidesplus PR (ethyca/fidesplus#3214) handles the Docker build and a TensorFlow/OpenSSL library loading conflict on the encoders image.
Code Changes
pyproject.toml: Bumppymssql==2.3.7→pymssql==2.3.13in[project.optional-dependencies](mssql and all extras); removepymssqlfrom[tool.uv] no-build-isolation-packageuv.lock: Auto-updated byuv lockto reflect the pymssql version changeSteps to Confirm
python -c "import pymssql; print(pymssql.version_info())"should showfreetds v1.4.27Pre-Merge Checklist
CHANGELOG.mdupdatedSummary by CodeRabbit