Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…sment-card-updates
Greptile SummaryThis PR makes a small, focused UI improvement to the assessment cards: the card title is now a clickable
Confidence Score: 5/5
Last reviewed commit: 6aae0de |
| <Title level={5} className={`!m-0 ${styles.titleLink}`}> | ||
| <NextLink href={`${PRIVACY_ASSESSMENTS_ROUTE}/${assessment.id}`}> | ||
| {assessment.name} | ||
| </NextLink> | ||
| </Title> |
There was a problem hiding this comment.
See if you can use the title prop on the card. It should render <NextLink /> correctly.
There was a problem hiding this comment.
I just tried it, the card header title has ellipsis by default with no built-in option to turn it off. I tried overriding the white-space style and it worked, but then I needed to adjust the card header & body padding too. It started to feel to hacky and like it's better off leaving it for a change to the Card HOC and a design system decision.
Ticket ENG-2906
Description Of Changes
Makes the assessment card title a clickable link that navigates to the individual assessment detail page. The link uses the card's text color (not the default blue link color) to keep the visual appearance consistent with the existing card design.
Code Changes
clients/admin-ui/src/features/privacy-assessments/AssessmentCard.tsx- Wrap the card title in aNextLinkpointing to the assessment detail routeclients/admin-ui/src/features/privacy-assessments/AssessmentCard.module.scss- Add.titleLinkstyle to override Ant Design link color tokens so the title renders in text color rather than the default link blueSteps to Confirm
/privacy-assessments/<id>)Pre-Merge Checklist
CHANGELOG.mdupdated