Skip to content

Assessment cards UI updates#7585

Merged
lucanovera merged 4 commits intomainfrom
ENG-2906-FE-Assessment-card-updates
Mar 20, 2026
Merged

Assessment cards UI updates#7585
lucanovera merged 4 commits intomainfrom
ENG-2906-FE-Assessment-card-updates

Conversation

@lucanovera
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera commented Mar 6, 2026

Ticket ENG-2906

Description Of Changes

Makes the assessment card title a clickable link that navigates to the individual assessment detail page. The link uses the card's text color (not the default blue link color) to keep the visual appearance consistent with the existing card design.

Code Changes

  • clients/admin-ui/src/features/privacy-assessments/AssessmentCard.tsx - Wrap the card title in a NextLink pointing to the assessment detail route
  • clients/admin-ui/src/features/privacy-assessments/AssessmentCard.module.scss - Add .titleLink style to override Ant Design link color tokens so the title renders in text color rather than the default link blue

Steps to Confirm

  1. Navigate to the Privacy Assessments list page
  2. Verify each assessment card title is clickable
  3. Click a title and confirm it navigates to the correct assessment detail page (/privacy-assessments/<id>)
  4. Verify the title text color matches the surrounding card text (not blue)

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

@lucanovera lucanovera requested a review from kruulik March 6, 2026 13:51
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Mar 20, 2026 3:18pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Mar 20, 2026 3:18pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18b3a51f-998d-4a7d-82ac-0a34489b5d18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ENG-2906-FE-Assessment-card-updates

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucanovera lucanovera marked this pull request as ready for review March 6, 2026 13:53
@lucanovera lucanovera requested a review from a team as a code owner March 6, 2026 13:53
@lucanovera lucanovera requested review from gilluminate and removed request for a team and gilluminate March 6, 2026 13:53
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 6, 2026

Greptile Summary

This PR makes a small, focused UI improvement to the assessment cards: the card title is now a clickable NextLink that navigates to the individual assessment detail page (/privacy-assessments/<id>), alongside the existing "View"/"Resume" buttons that already provided that navigation.

  • AssessmentCard.tsx: Imports NextLink and PRIVACY_ASSESSMENTS_ROUTE, wraps the Title content in a link, and adds !m-0 + .titleLink to the Title className. The assessment.id used in the URL is a required (non-optional) field on the underlying PrivacyAssessmentResponse type, so there is no null-safety concern.
  • AssessmentCard.module.scss: Adds .titleLink which overrides Ant Design v5 CSS token variables (--ant-color-link, --ant-color-link-hover, --ant-color-link-active) so the title renders in the standard text color rather than the default link blue. Setting these on the Title (h5) element is correct — CSS custom property inheritance propagates the values to the nested anchor tag rendered by NextLink.
  • No new issues were introduced. The change is minimal, consistent with existing patterns in the codebase (e.g. AssessmentGroup.tsx already constructs the same route for navigation), and the styling approach is appropriate for Ant Design v5's token system.

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal UI-only change with no logic, data, or API impact.
  • The change is small (2 files, ~10 lines), purely presentational, consistent with existing navigation patterns already in place, and uses well-established Next.js and Ant Design v5 patterns. No new dependencies, no API changes, and the id field used in the URL is typed as required.
  • No files require special attention.

Last reviewed commit: 6aae0de

Copy link
Copy Markdown
Contributor

@kruulik kruulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lucanovera lucanovera added this pull request to the merge queue Mar 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 6, 2026
Comment on lines +76 to +80
<Title level={5} className={`!m-0 ${styles.titleLink}`}>
<NextLink href={`${PRIVACY_ASSESSMENTS_ROUTE}/${assessment.id}`}>
{assessment.name}
</NextLink>
</Title>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if you can use the title prop on the card. It should render <NextLink /> correctly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it, the card header title has ellipsis by default with no built-in option to turn it off. I tried overriding the white-space style and it worked, but then I needed to adjust the card header & body padding too. It started to feel to hacky and like it's better off leaving it for a change to the Card HOC and a design system decision.

@lucanovera lucanovera enabled auto-merge March 20, 2026 15:21
@lucanovera lucanovera added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 452fddb Mar 20, 2026
45 of 46 checks passed
@lucanovera lucanovera deleted the ENG-2906-FE-Assessment-card-updates branch March 20, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants