log caught redis_version_cached exception#7538
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryThis PR improves exception logging in the Redis version cache utility by upgrading from DEBUG to EXCEPTION level logging. The changes ensure that when Redis becomes unavailable, the full exception details and stack traces are properly captured in logs, making debugging production issues significantly easier. Key changes:
Impact:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: a5854db |
| logger.exception( | ||
| "redis_version_cache '{}': Redis unavailable, returning stale cached value. Exception: {}", | ||
| cache_key, | ||
| e, | ||
| ) |
There was a problem hiding this comment.
inconsistent string formatting - remove f prefix to match codebase pattern
| logger.exception( | |
| "redis_version_cache '{}': Redis unavailable, returning stale cached value. Exception: {}", | |
| cache_key, | |
| e, | |
| ) | |
| logger.exception( | |
| "redis_version_cache '{}': Redis unavailable, returning stale cached value. Exception: {}", | |
| cache_key, | |
| e, | |
| ) |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| logger.exception( | ||
| "redis_version_cache '{}': Redis unavailable and no cached value, calling function directly. Exception: {}", | ||
| cache_key, | ||
| e, | ||
| ) |
There was a problem hiding this comment.
inconsistent string formatting - remove f prefix to match codebase pattern
| logger.exception( | |
| "redis_version_cache '{}': Redis unavailable and no cached value, calling function directly. Exception: {}", | |
| cache_key, | |
| e, | |
| ) | |
| logger.exception( | |
| "redis_version_cache '{}': Redis unavailable and no cached value, calling function directly. Exception: {}", | |
| cache_key, | |
| e, | |
| ) |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
@greptile |
|
bypassing merge queue and branch protection rules (at least, attempting to!) in order to get this into |
Description Of Changes
We're swallowing caught
Exceptions with only a DEBUG log that doesn't include the underlying exception information.Code Changes
EXCEPTIONlevel to include full stack trace of underlying exceptionSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works