tweaked positioning and spacing

[kruulik]

Refinements to chart components and dark theme config.

• Switch chart imports from antd to antd/lib
• Add animation state management (charts stop animating after first run)
• Add aspect prop to RadarChart
• Add Card colorBgContainer to dark theme config

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ignored	Preview	Mar 2, 2026 8:44pm
fides-privacy-center	Ignored		Mar 2, 2026 8:44pm

[greptile-apps]

Greptile Summary

This PR refines chart components with optimized imports, animation state management, and dark theme improvements. The changes switch from antd to antd/lib imports for better tree-shaking, introduce a useChartAnimation hook to stop charts from continuously animating after their initial render, add an aspect prop to RadarChart for flexible sizing, and configure Card background colors in the dark theme.

• Switched chart imports from antd to antd/lib for tree-shaking optimization
• Implemented animation state management via new useChartAnimation hook that disables animation after first run (600ms default)
• Added aspect prop to RadarChart (defaults to 1) and changed from fixed height to aspect-based sizing
• Added Card colorBgContainer configuration to dark theme
• Animation state issue with theme changes previously noted in review threads

Confidence Score: 4/5

• This PR is safe to merge with minor refinements to chart components and theme configuration
• The implementation is clean and well-structured. Import optimizations and theme changes are straightforward. The animation state management works as intended for the stated goal. The previously flagged animation/theme-change behavior is a known tradeoff rather than a blocking issue
• The chart component files (RadarChart.tsx, Sparkline.tsx) have a known animation limitation with theme changes that was previously flagged, but all changes are otherwise safe

Important Files Changed

Filename	Overview
clients/fidesui/src/components/charts/RadarChart.tsx	Added animation state management, aspect ratio prop, and switched to antd/lib import. Animation theme-change issue previously flagged
clients/fidesui/src/components/charts/Sparkline.tsx	Added animation state management and switched to antd/lib import. Animation theme-change issue previously flagged
clients/fidesui/src/components/charts/chart-utils.ts	New utility hook to manage chart animation state (stops animating after first run)

_{Last reviewed commit: c3478e1}

[greptile-apps]

_{6 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[speaker-ender]

Overall looks good and approving.
Left some comments/questions but nothing that's a blocker.

[speaker-ender]

What is the rationale for the import change?
I think the normal import should export things correctly via esm and if not I think it's a different path.

[kruulik]

You are correct - it should all be imported from antd, however, the reason this worked was because it matched FidesUIProvider importing from antd/lib. Importing from antd breaks theming because they were resolving to two different modules.
FidesUIProvider should also be corrected, since importing from /lib is deprecated, but it will cause breaking changes to anything else that imports from antd/lib.

[speaker-ender]

yuck. yea we can deal with that later