Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR adds inline key display to dataset select dropdowns to help disambiguate datasets that share the same name but have different Fides keys, particularly for datasets promoted from Helios results. Key Changes
The implementation follows existing patterns, uses the fidesui Flex component appropriately, and handles the edge case where name equals key to avoid redundant display. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 187a156 |
| data?.items?.map((d) => ({ | ||
| value: d.fides_key, | ||
| label: d.ctl_dataset.name || d.fides_key, | ||
| })) ?? []; |
There was a problem hiding this comment.
Previously, the initial value was a key only and wouldn't render with the name either in the dropdown or in the select input itself, this just makes it consistent with the rest of the options.
…thyca/fides into jpople/eng-2754/dataset-select
| ); | ||
| }; | ||
|
|
||
| export default DatasetOption; |
There was a problem hiding this comment.
This name mismatching your imports is exactly why I hate default exports and prefer named exports. No need to change this, just pointing that out 😄
Ticket ENG-2754
Description Of Changes
Updates selects where datasets are selected to also display the dataset's Fides key inline to help disambiguate in cases where two datasets have the same name but different keys (mainly, if those datasets were promoted from Helios results).
Three selects are updated in the system inventory:
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated