Skip to content

Add key display to dataset selects#7512

Merged
jpople merged 9 commits intomainfrom
jpople/eng-2754/dataset-select
Feb 27, 2026
Merged

Add key display to dataset selects#7512
jpople merged 9 commits intomainfrom
jpople/eng-2754/dataset-select

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Feb 26, 2026

Ticket ENG-2754

Description Of Changes

Updates selects where datasets are selected to also display the dataset's Fides key inline to help disambiguate in cases where two datasets have the same name but different keys (mainly, if those datasets were promoted from Helios results).

Screenshot 2026-02-26 at 16 55 09

Three selects are updated in the system inventory:

  • main system information form
  • privacy declaration form
  • integration tab on a completed DSR integration
  • "add condition" form on integrations

Steps to Confirm

  1. Create some datasets via Helios promotion so they have long keys
  2. View the dataset selects above
  3. Confirm options render correctly and forms still function correctly

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • UX feedback:
    • All UX related changes have been reviewed by a designer
  • Followup issues:
    • No followup issues

@jpople jpople requested a review from a team as a code owner February 26, 2026 23:26
@jpople jpople requested review from lucanovera and removed request for a team February 26, 2026 23:26
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 27, 2026 4:07pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 27, 2026 4:07pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

This PR adds inline key display to dataset select dropdowns to help disambiguate datasets that share the same name but have different Fides keys, particularly for datasets promoted from Helios results.

Key Changes

  • Created DatasetSelectOption component that displays both the dataset name and key inline when they differ
  • Updated dataset option construction in useDatasetConfigField to separate label (name) from value (key)
  • Applied the new option renderer to dataset selects in system information form, privacy declaration form, and integration configuration

The implementation follows existing patterns, uses the fidesui Flex component appropriately, and handles the edge case where name equals key to avoid redundant display.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward UI improvements with no logic complexity or side effects. A bug introduced in the first commit was properly fixed in the second commit. All changes follow established patterns and custom rules, with proper type safety maintained throughout.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/dataset/DatasetSelectOption.tsx New component that renders dataset options with both name and key displayed inline, with proper truncation and styling
clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/fields/DatasetConfigField/useDatasetConfigField.tsx Updated dataset option creation to use name as label and key as value, enabling the new DatasetSelectOption component to display both
clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx Added optionRender prop to dataset select to use the new DatasetSelectOption component
clients/admin-ui/src/features/system/SystemInformationForm.tsx Added React import and optionRender prop to dataset select for consistent key display
clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationForm.tsx Added optionRender prop to dataset select in privacy declaration form for key disambiguation

Last reviewed commit: 187a156

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

data?.items?.map((d) => ({
value: d.fides_key,
label: d.ctl_dataset.name || d.fides_key,
})) ?? [];
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, the initial value was a key only and wouldn't render with the name either in the dropdown or in the select input itself, this just makes it consistent with the rest of the options.

);
};

export default DatasetOption;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name mismatching your imports is exactly why I hate default exports and prefer named exports. No need to change this, just pointing that out 😄

@jpople jpople enabled auto-merge February 27, 2026 16:03
@jpople jpople added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit 1ff8f33 Feb 27, 2026
43 checks passed
@jpople jpople deleted the jpople/eng-2754/dataset-select branch February 27, 2026 16:28
jpople added a commit that referenced this pull request Feb 27, 2026
jpople added a commit that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants