Skip to content

remove wireframe global setting from Ant Theme#7509

Merged
gilluminate merged 1 commit intomainfrom
gill/ant-theme-fix
Feb 26, 2026
Merged

remove wireframe global setting from Ant Theme#7509
gilluminate merged 1 commit intomainfrom
gill/ant-theme-fix

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

This was unintentionally added to the initial iteration of our theme file. We do not want the extra styling it provides.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Feb 26, 2026 8:37pm
fides-privacy-center Ignored Ignored Feb 26, 2026 8:37pm

Request Review

@jack-gale-ethyca jack-gale-ethyca self-requested a review February 26, 2026 20:49
@gilluminate gilluminate marked this pull request as ready for review February 26, 2026 20:52
@gilluminate gilluminate requested a review from a team as a code owner February 26, 2026 20:52
@gilluminate gilluminate requested review from speaker-ender and removed request for a team February 26, 2026 20:52
@gilluminate gilluminate added this pull request to the merge queue Feb 26, 2026
@gilluminate gilluminate removed the request for review from speaker-ender February 26, 2026 20:52
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Removes the wireframe: true global token from the Ant Design theme configuration. The wireframe setting applies minimal, outline-based styling to all Ant components, which was unintentionally added and is not desired for the application's visual design.

  • Removes single line configuration that affected global component styling
  • Clean removal with no side effects or dependencies
  • Aligns with intended design system

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a simple, intentional removal of a single configuration property that was unintentionally added. It's a pure styling change with no logical errors, security concerns, or breaking functionality. The modification is well-explained and straightforward.
  • No files require special attention

Important Files Changed

Filename Overview
clients/fidesui/src/ant-theme/default-theme.ts Removed unintended wireframe: true setting from Ant Design theme configuration

Last reviewed commit: e814658

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Merged via the queue into main with commit c090d40 Feb 26, 2026
38 of 39 checks passed
@gilluminate gilluminate deleted the gill/ant-theme-fix branch February 26, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants