Skip to content

Revert "[ENG-2175] Redis clustering"#7496

Merged
adamsachs merged 1 commit intomainfrom
revert-7487-johnewart/ENG-2175
Feb 26, 2026
Merged

Revert "[ENG-2175] Redis clustering"#7496
adamsachs merged 1 commit intomainfrom
revert-7487-johnewart/ENG-2175

Conversation

@adamsachs
Copy link
Copy Markdown
Contributor

Reverts #7487.

This seems to have broken our nightly dev environment, so we're reverting temporarily to try and restore that environment while we understand and fix the issue.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Feb 26, 2026 0:04am
fides-privacy-center Ignored Ignored Feb 26, 2026 0:04am

Request Review

@adamsachs adamsachs marked this pull request as ready for review February 26, 2026 12:04
@adamsachs adamsachs requested a review from a team as a code owner February 26, 2026 12:04
@adamsachs adamsachs requested review from galvana and removed request for a team February 26, 2026 12:04
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

This PR cleanly reverts #7487 which added Redis clustering support. The revert is necessary because the original changes broke the nightly dev environment.

Key changes reverted:

  • Removed celery-redis-cluster dependency and downgraded redis from 7.2.0 to 3.5.3
  • Removed Redis cluster configuration (cluster_enabled setting and cluster connection URL logic)
  • Reverted FidesopsRedis from wrapper class back to Redis extension
  • Removed Redis cluster nodes from docker-compose.yml
  • Removed cluster-specific tests and CI workflows
  • Reverted model methods from get_keys_by_prefix() back to cache.keys()

Note on PR size: This PR changes 16 files with 959 total line changes, which exceeds the repository's guideline of 15 files or 500 lines. However, this is an emergency revert to restore a broken environment, which justifies the exception. The revert is a clean git revert (matching the original commit's stats exactly: 828 deletions here vs 828 insertions in the original), making it low-risk despite the size.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk as it's a clean git revert
  • This is a clean git revert that exactly undoes PR [ENG-2175] Redis clustering #7487. The line change statistics match perfectly (828 deletions here vs 828 insertions in the original commit), confirming this is a complete revert with no partial changes or cherry-picking. Reverts are inherently low-risk as they restore previously working code. The justification for the revert (broken dev environment) is clear and documented.
  • No files require special attention - all changes are part of a clean git revert

Important Files Changed

Filename Overview
src/fides/api/util/cache.py reverted from wrapper class to Redis extension, removed cluster-aware methods
src/fides/config/redis_settings.py removed cluster_enabled setting and get_cluster_connection_url method
src/fides/api/tasks/init.py removed celery-redis-cluster import and cluster URL logic
pyproject.toml downgraded redis from 7.2.0 to 3.5.3, removed celery-redis-cluster dependency
docker-compose.yml removed 3 Redis cluster nodes and cluster init service
tests/ops/util/test_cache.py removed cluster mode tests and cluster fixture

Last reviewed commit: c74004c

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@adamsachs adamsachs enabled auto-merge February 26, 2026 12:20
@adamsachs adamsachs added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit 56f21ee Feb 26, 2026
52 of 54 checks passed
@adamsachs adamsachs deleted the revert-7487-johnewart/ENG-2175 branch February 26, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants