Skip to content

Fix Slack OAuth authorize URL path#7466

Merged
galvana merged 2 commits intomainfrom
fix/chat-slack-authorize-url
Feb 24, 2026
Merged

Fix Slack OAuth authorize URL path#7466
galvana merged 2 commits intomainfrom
fix/chat-slack-authorize-url

Conversation

@galvana
Copy link
Copy Markdown
Contributor

@galvana galvana commented Feb 24, 2026

Description Of Changes

Fix the Slack OAuth authorize URL in the admin UI. The frontend was navigating to /api/v1/plus/chat/authorize but the backend route is mounted at /api/v1/plus/chat/slack/authorize, resulting in a 404 when users clicked "Authorize" to initiate the Slack OAuth flow.

Code Changes

  • clients/admin-ui/src/features/chat-provider/forms/SlackChatForm.tsx - Fix authorize URL from /chat/authorize to /chat/slack/authorize (with and without config_id)
  • clients/admin-ui/src/features/chat-provider/ChatConfigurations.tsx - Fix authorize URL in the configurations table "Authorize" button

Steps to Confirm

  1. Navigate to the Chat Provider settings page in the admin UI
  2. Configure a Slack chat provider with client ID and secret
  3. Click "Authorize" — should redirect to Slack's OAuth page instead of returning a 404

Pre-Merge Checklist

  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • No UX review needed
  • Followup issues:
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

Made with Cursor

The frontend was using /chat/authorize but the backend route is
mounted at /chat/slack/authorize. This caused a 404 when initiating
the Slack OAuth flow from either the config form or the configurations
table.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 24, 2026 0:31am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 24, 2026 0:31am

Request Review

Co-authored-by: Cursor <cursoragent@cursor.com>
@galvana galvana marked this pull request as ready for review February 24, 2026 00:27
@galvana galvana requested a review from a team as a code owner February 24, 2026 00:27
@galvana galvana requested review from speaker-ender and removed request for a team and speaker-ender February 24, 2026 00:27
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 24, 2026

Greptile Summary

Fixed the Slack OAuth authorize URL path from /api/v1/plus/chat/authorize to /api/v1/plus/chat/slack/authorize to match the backend route, resolving 404 errors when users clicked "Authorize" to initiate the Slack OAuth flow.

  • Updated authorize URL in ChatConfigurations.tsx Authorize button (line 224)
  • Updated authorize URL in SlackChatForm.tsx handleAuthorize function for both paths with and without config_id parameter (lines 148-149)
  • Added changelog entry documenting the fix

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward URL path corrections that fix a bug. The fix is applied consistently across both locations where the authorize URL is used, and the pattern follows the existing OAuth authorize URL pattern seen elsewhere in the codebase (e.g., /api/v1/plus/openid-provider/{identifier}/authorize). The changes are minimal, well-scoped, and fix a functional bug without introducing new logic or complexity.
  • No files require special attention

Important Files Changed

Filename Overview
changelog/7466-fix-slack-authorize-url.yaml Added changelog entry documenting the Slack OAuth URL fix
clients/admin-ui/src/features/chat-provider/ChatConfigurations.tsx Fixed authorize URL in the Authorize button from /chat/authorize to /chat/slack/authorize
clients/admin-ui/src/features/chat-provider/forms/SlackChatForm.tsx Fixed authorize URL in handleAuthorize function from /chat/authorize to /chat/slack/authorize

Last reviewed commit: 21bdd7c

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@thabofletcher thabofletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @galvana!

@galvana galvana added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 442d695 Feb 24, 2026
45 checks passed
@galvana galvana deleted the fix/chat-slack-authorize-url branch February 24, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants