Skip to content

Fix transition UI bug in datamap report#7465

Merged
lucanovera merged 4 commits intomainfrom
ENG-2061-Drawer-in-datamap-report-shows-previously-selected-item-for-a-second-while-it-opens
Feb 25, 2026
Merged

Fix transition UI bug in datamap report#7465
lucanovera merged 4 commits intomainfrom
ENG-2061-Drawer-in-datamap-report-shows-previously-selected-item-for-a-second-while-it-opens

Conversation

@lucanovera
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera commented Feb 24, 2026

Ticket ENG-2061

Description Of Changes

Fixes an issue where if you go to the datamap report and open the details for different systems, sometimes you will see the details of the previously selected system for 1-2s before it updates.

Code Changes

  • Use currentData instead of data for RTK hook to avoid using stale data

Steps to Confirm

  1. Open datamap report
  2. Click on a system name and the drawer should open
  3. Close the drawer
  4. Click on a different system while paying attention to the drawer opening again
  5. Check that while the drawer opens a loading state is showing and it's not showing the details of the previously selected system

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 24, 2026 11:41pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 24, 2026 11:41pm

Request Review

@lucanovera lucanovera marked this pull request as ready for review February 24, 2026 00:24
@lucanovera lucanovera requested a review from a team as a code owner February 24, 2026 00:24
@lucanovera lucanovera requested review from gilluminate and removed request for a team February 24, 2026 00:24
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 24, 2026

Greptile Summary

This PR fixes a UI transition bug in the datamap report drawer where previously selected system details briefly appeared when opening a different system.

Key changes:

  • Changed from data to currentData in the RTK Query hook useGetSystemByFidesKeyQuery to prevent cached stale data from displaying during system transitions
  • Added proper changelog entry

RTK Query behavior:

  • data returns the last successful query result and persists it even when parameters change, which causes stale data to show during transitions
  • currentData only returns data for the current query parameters and becomes undefined when parameters change, allowing the loading state to display correctly

The fix is minimal, targeted, and correctly addresses the root cause of the issue.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a single-line fix that correctly addresses a well-defined UI bug by using the appropriate RTK Query return property. The fix follows RTK Query best practices and has no risk of breaking existing functionality.
  • No files require special attention

Important Files Changed

Filename Overview
changelog/7465-fix-datamap-drawer-stale-system.yaml Properly formatted changelog entry describing the bug fix
clients/admin-ui/src/features/datamap/datamap-drawer/DatamapDrawer.tsx Changed from data to currentData in RTK Query hook to prevent stale data from showing during transitions

Last reviewed commit: 2803828

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion

@lucanovera lucanovera added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 97d7d19 Feb 25, 2026
45 checks passed
@lucanovera lucanovera deleted the ENG-2061-Drawer-in-datamap-report-shows-previously-selected-item-for-a-second-while-it-opens branch February 25, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants