add linked systems to connection config get#7458
Merged
Conversation
…ngelog Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Greptile SummaryThis PR adds a Key changes:
Minor issue:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 990f8c0 |
galvana
approved these changes
Feb 25, 2026
10 tasks
adamsachs
added a commit
that referenced
this pull request
Feb 27, 2026
- Time DB query separately from serialization in the transformer - Add GET /connection_legacy that replicates pre-#7458 behavior (no selectinload, no transformer, no from_connection_config) for direct A/B perf comparison on deployed environments Made-with: Cursor
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2590
Based off #7432
Description Of Changes
Adds a
linked_systemsfield to the connection config GET endpoints (both list and detail), exposing which system(s) are linked to each connection config. This is part of the broader system-integration link effort.Code Changes
Schema (
connection_config.py):LinkedSystemInfoschema withfides_keyandnamelinked_systems: List[LinkedSystemInfo]field toConnectionConfigurationResponsesystemfield +@model_validator(mode="after")to populatelinked_systemsfrom the ORM.systemrelationship during serialization -- no changes to the coreConnectionConfigmodelConnectionConfigurationResponseWithSystemKeyto inherit fromConnectionConfigurationResponse(instead ofResponseBase), so the detail endpoint also returnslinked_systemsRoute (
connection_endpoints.py):selectinload(ConnectionConfig.system)to the list endpoint query to avoid N+1 queries. Scoped to this endpoint only -- the detail endpoint uses standard lazy loading (single object)Design docs: Updated section 2.4 of the technical design doc with implementation details and response example
Tests: Updated key assertions in existing tests and added new tests verifying
linked_systemsis empty for unlinked configs and correctly populated for linked configs (both list and detail endpoints)Steps to Confirm
GET /api/v1/connection-- each item should includelinked_systems: []orlinked_systems: [{fides_key: "...", name: "..."}]GET /api/v1/connection/{key}-- should includelinked_systemsalongside the existingsystem_keyConnectionConfigurationResponse(e.g. webhook responses) also includelinked_systemsConfirmed this is populating in our new UI column (

Linked system) as expected:Pre-Merge Checklist
CHANGELOG.mdupdated