Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Greptile SummaryThis PR establishes the foundational data model and validation logic for domain validation in SaaS connector parameters. The implementation adds an Key Changes:
Important Note: This is Part 1 of a 3-part series. The validation functions are defined but runtime enforcement during actual connector operations is not yet implemented. This PR focuses on the data model and config-time validation only. Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 5a61a2d |
galvana
reviewed
Feb 26, 2026
…x to match at least 1 character
galvana
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2569
Description Of Changes
First of a 4-part series adding core domain validation for SaaS connector parameters. This PR establishes the foundational data model and validation logic.
typeandallowed_valuesfields toConnectorParam, replacing the previousallowed_domainsattribute.type="endpoint"designates parameters requiring value validation. Forallowed_values:Nonemeans no validation,[]means self-hosted (any value), and a populated list restricts to those wildcard patterns.enable_connector_param_allowed_valuessecurity config flag gated by dev mode.domain_util.py,validate_value_against_allowed_list).client_config.hostplaceholders reference connector params oftype="endpoint"withallowed_valuesdefined.runtime enforcement is added in Parts 2 and 3
Code Changes
typeandallowed_valuesfields toConnectorParaminsaas_config.pySaaSConfig.validate_host_domain_restrictionsmodel validator and_collect_client_config_hostshelpersrc/fides/api/util/domain_util.pywithwildcard_to_regexis_domain_validation_disabledandvalidate_value_against_allowed_listtosaas_util.pyenable_connector_param_allowed_valuestoSecuritySettingsstripe_config.ymlwithtype: endpointandallowed_valueson the domain paramSteps to Confirm
SaaSConfigwithtype="endpoint"andallowed_valueson a connector param and a host placeholder referencing that param passes validationclient_config.hostat a param withouttype="endpoint"orallowed_values(when another param has it) raises a validation errortype="endpoint"params skip validation entirelyPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works