Remove drill performance tests from CI#7417
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryRemoves the Drill-based performance test job ( Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 2088675 |
adamsachs
left a comment
There was a problem hiding this comment.
👍 this seems like good cleanup to me.
because i think it's always good to get extra opinions before removing things, i'll ask @nrxsmith to comment on whether he's comfortable removing this path for performance testing and relying more wholesale on his performance testing suite/framework!
|
@greptile re-review. The code is not orphaned since one can still run the load test nox session locally, it's just not part of CI anymore |
I think this is ok, but I'm curious what y'all think of the endpoints its testing. Looks like:
Some of these we're testing already, but maybe worth adding some more some of these others? My guess is these are kind of old, so maybe there are better ones to test for performance responses; a backlog thing for me. |
Ticket []
Description Of Changes
The drill performance checks are failing on install. After a closer look, these aren't much of a load /performance test anyways and we're already running performance / load tests regularly on deployed envs, so we can safely remove.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works