refactor: monitor fields filters [ENG-2450]

[speaker-ender]

Ticket ENG-2450

Description Of Changes

Refactoring the search filters on the monitor fields screen to be dropdowns instead of using the tree filter component

Code Changes

• Improved the useSearchForm hook to have better types
• Added a new search filter component for the monitor fields screen

Steps to Confirm

1. Visit the Action Center screen
2. Confirm that all of the filters function as expected and update the url
3. Click on an available Datastore monitor type
4. Confirm that the filters are now matching the new select/filter bar style
5. Verify that there are no regressions in the filtering functionality (updating results, updating url, refreshing available filters)

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated
  • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
  • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Updates unreleased work already in Changelog, no new entry necessary
• UX feedback:
  • All UX related changes have been reviewed by a designer
  • No UX review needed
• Followup issues:
  • Followup issues created
  • No followup issues
• Database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!
  • No migrations
• Documentation:
  • Documentation complete, PR opened in fidesdocs
  • Documentation issue created in fidesdocs
  • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • No documentation updates required

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Feb 23, 2026 6:09pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Feb 23, 2026 6:09pm

[greptile-apps]

Greptile Summary

This PR refactors the monitor fields screen filters from a tree-based Filter component to dropdown Select components, introducing valibot for schema validation alongside the existing nuqs URL state management. The useSearchForm hook is updated to support valibot schemas and a form submission flow (onFieldsChange → form.submit() → onFinish with validation). The old MonitorFieldFilters (406 lines) and useMonitorFieldsFilters hook are replaced by the new MonitorFieldsSearchForm component and MonitorFieldSearchForm.util.ts.

• Adds valibot as a new dependency and bumps nuqs from ^2.4.3 to ^2.8.8
• Adds "Datastore Filters" RTK Query cache tag with proper invalidation across multiple mutation endpoints
• Removes trailing ellipsis from status labels (e.g., "Classifying..." → "Classifying") for cleaner dropdown display
• The useFilters.ts file is no longer imported anywhere but was not deleted — it should be cleaned up
• The data-testid="monitor-type-filter" on the status dropdown appears to be a copy-paste error from MonitorListSearchForm
• requestData from useSearchForm is destructured but unused in page.tsx, while filter values are read imperatively via form.getFieldValue() — consider using the reactive requestData instead

Confidence Score: 3/5

• Generally safe refactor with minor issues that should be addressed before merge.
• The core refactoring logic is sound — replacing the tree filter with dropdowns and adding valibot validation. However, there are a few issues: a misleading data-testid that could break or confuse tests, redundant filtering logic, an orphaned useFilters.ts file, and the use of imperative form reads instead of reactive state for query parameters. None of these are showstoppers, but they represent code quality concerns worth addressing.
• Pay close attention to fields/page.tsx (imperative form reads for query construction) and MonitorFieldsSearchForm.tsx (incorrect data-testid, redundant filter logic).

Important Files Changed

Filename	Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useSearchForm.ts	Refactored to use valibot schema validation and form submission pattern instead of inline value translation. Minor typo in comment.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/forms/MonitorFieldsSearchForm.tsx	New search form component with dropdown filters. Has redundant filter logic in data category options builder and a copy-pasted data-testid that misidentifies the element.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/forms/MonitorFieldSearchForm.util.ts	New utility defining valibot schema, nuqs query state, and type for the monitor field search form. Clean separation of concerns.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx	Replaced old filter component and search with new form-based approach. Uses imperative form.getFieldValue() instead of reactive state for query construction; requestData is unused.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFields.const.ts	Removed trailing ellipsis from status labels (e.g., "Classifying..." → "Classifying"). Consistent update across all mappings.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.const.ts	Added valibot schema and type for the monitor search form. Changed search default from empty string to parseAsString (nullable).
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.tsx	Updated to use new schema-based useSearchForm pattern and onFinish-based pagination reset.
clients/admin-ui/src/features/data-discovery-and-detection/discovery-detection.slice.ts	Added "Datastore Filters" invalidation tag to multiple mutation endpoints for automatic filter refresh.

_{Last reviewed commit: ac052af}

[greptile-apps]

_{15 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

[gilluminate]

Greptile's feedback seems legit, and I agree with those. Three nitpicks of my own to add to that.