Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Greptile OverviewGreptile SummaryThis PR adds Changes:
The implementation follows established patterns for enum migrations and correctly handles the schema validation issue where Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 6d543fa |
thabofletcher
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2663
Description Of Changes
Add
policy_evaluatedto theAuditLogActionenum to support audit logging when policies are conditionally evaluated during privacy request creation. Also addsdefault_policiesas an optional field on theApplicationConfigschema to fix a validation error when the PATCH/configendpoint tries to deserializeapi_setdata that containsdefault_policies(written by the default policy config routes).Code Changes
src/fides/api/models/audit_log.py- Addpolicy_evaluatedenum value toAuditLogActionsrc/fides/api/alembic/migrations/versions/xx_2026_02_13_2351_a0109cdde920_...py- Alembic migration to add the enum value to the PostgreSQL type. Downgrade updates existing rows tofinishedrather than deleting them.src/fides/api/schemas/application_config.py- Adddefault_policies: Optional[Dict[str, Optional[str]]]toApplicationConfigschema to preventextra_forbiddenvalidation errorSteps to Confirm
alembic upgrade headpolicy_evaluatedis a valid enum value:SELECT enum_range(NULL::auditlogaction);/api/v1/configwith any valid payload on an instance that hasdefault_policiesinapi_set— should no longer raiseextra_forbiddenPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and worksMade with Cursor