Skip to content

remove resource counts from monitor deletion modal#7389

Merged
adamsachs merged 1 commit intomainfrom
asachs/ENG-1192_v2
Feb 13, 2026
Merged

remove resource counts from monitor deletion modal#7389
adamsachs merged 1 commit intomainfrom
asachs/ENG-1192_v2

Conversation

@adamsachs
Copy link
Copy Markdown
Contributor

@adamsachs adamsachs commented Feb 13, 2026

Ticket ENG-1192 followup

Description Of Changes

Per discussion referenced in the jira comment here, these resources counts ultimately just add confusion for the end user, so we're deciding to hide it.

Code Changes

  • don't show resource counts, but add explanatory comment

Steps to Confirm

  1. new modal text looks like
image

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 13, 2026 5:38pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 13, 2026 5:38pm

Request Review

@adamsachs adamsachs marked this pull request as ready for review February 13, 2026 17:36
@adamsachs adamsachs requested a review from a team as a code owner February 13, 2026 17:36
@adamsachs adamsachs requested review from gilluminate and speaker-ender and removed request for a team and gilluminate February 13, 2026 17:36
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

Removed the staged_resource_count display from the monitor deletion modal to eliminate user confusion. The count was misleading because it didn't accurately represent all resources being deleted (some approved/ignored staged resources were also being deleted but not included in the count).

Key changes:

  • Removed the conditional block showing pending resource count
  • Added a comprehensive comment explaining why staged_resource_count was intentionally omitted
  • Added clearer messaging: "All action center resources discovered by this monitor will be permanently deleted"
  • Backend API still exposes the count for direct inspection if needed

The change improves UX by providing clear, accurate information about deletion impact without potentially confusing numeric details.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple UI improvement that removes a confusing metric from a modal. It includes a thorough explanatory comment, improves user messaging, and doesn't affect any core functionality or data operations. The backend API still exposes the data if needed for other purposes.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/integrations/configure-monitor/MonitorConfigActionsCell.tsx Removed confusing resource count display from monitor deletion modal, added clear explanatory comment and improved messaging about what will be deleted

Last reviewed commit: 3864538

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@nrxsmith nrxsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamsachs adamsachs added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit 9961248 Feb 13, 2026
44 of 45 checks passed
@adamsachs adamsachs deleted the asachs/ENG-1192_v2 branch February 13, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants