Migrate full page spinners from Chakra to Ant Design#7371
Merged
gilluminate merged 3 commits intomainfrom Feb 13, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
9d90b42 to
ad75416
Compare
ad75416 to
54f2728
Compare
Contributor
Greptile OverviewGreptile SummaryMigrated full-page spinners from Chakra UI's
Confidence Score: 4/5
Important Files Changed
|
speaker-ender
approved these changes
Feb 12, 2026
Contributor
speaker-ender
left a comment
There was a problem hiding this comment.
Overall looks good.
Left some minor thoughts around implementation but not a blocker.
| alignment?: "center" | "start" | "end"; | ||
| } | ||
|
|
||
| export const PageSpinner = ({ |
Contributor
There was a problem hiding this comment.
It seems like this is used in places that aren't always a page.
Also wondering if we need this component and the layout/positioning should be a separate concern.
Understand it being a worth while convenience though.
Contributor
Author
There was a problem hiding this comment.
open to suggestions. I realized that when I named it, but couldn't think of a cleaner alternative
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-182
Description Of Changes
This is the first iteration of migrating all spinners. This PR is just to replace the custom Chakra-based
FidesSpinnercomponent inadmin-uiwith a new Ant Design-basedPageSpinnercomponent infidesui. Migrates all standalone spinner usages across the admin UI to use the new component, and remove the now-unusedFidesSpinner. Also reorganizefidesuiexports to group custom components by category (data-entry, feedback, navigation) and move them out of the deprecated ChakraUI section.Code Changes
PageSpinnercomponent tofidesuiusing Ant Design'sSpinwrapped in aFlexfor alignmentFidesSpinnerfromadmin-ui/src/features/common/FidesSpinnertoPageSpinneracross integration, monitor, manual tasks, attachments, taxonomy, data catalog, and system configuration pagesFidesSpinnerwrapper (the AntTablecomponent has its own built-inloadingprop)fidesui/src/index.tsexports to group custom components by category and separate them from deprecated ChakraUI componentsSteps to Confirm