Skip to content

Disable bulk add in website monitor results when adding uncategorized assets#7359

Merged
jpople merged 2 commits intomainfrom
jpople/eng-2609/disable-add-web-monitor-resources
Feb 11, 2026
Merged

Disable bulk add in website monitor results when adding uncategorized assets#7359
jpople merged 2 commits intomainfrom
jpople/eng-2609/disable-add-web-monitor-resources

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Feb 11, 2026

Ticket ENG-2609

Description Of Changes

Fixes a bug where uncategorized assets (without systems) could be selected and added from the bulk action menu. This PR disables the "Add" option when any of the selected assets lack an assigned system, which aligns the bulk action behavior with the "Add all" button and inline "Add" button which are both already disabled appropriately.

Screenshot 2026-02-11 at 10 42 44

Steps to Confirm

  1. Create and run a website monitor
  2. View the results
  3. In results under a system, should be able to select and add as normal
  4. In results under uncategorized, when selecting multiple assets without systems, "Add" should be disabled in the actions menu

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner February 11, 2026 16:49
@jpople jpople requested review from lucanovera and removed request for a team February 11, 2026 16:49
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 11, 2026 4:57pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 11, 2026 4:57pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 11, 2026

Greptile Overview

Greptile Summary

This PR updates the Action Center website monitor results bulk actions so that the "Add" menu item is disabled whenever the current selection includes any uncategorized assets (i.e., assets without an assigned system). It also adds a tooltip explaining why the action is disabled, bringing the bulk action behavior in line with the existing inline "Add" and "Add all" controls that already block adding assets lacking a system.

Change is localized to the UI table component and relies on selectedRows from useDiscoveredAssetsTable (which is backed by the shared useAntTable selection state) to determine whether any selected asset is missing system.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change is small and localized to a single UI component, uses existing selection state (selectedRows) that is already treated as an array elsewhere, and only tightens UI gating for an action that was previously erroneously enabled. No API/schema changes or side effects were introduced.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/tables/DiscoveredAssetsTable.tsx Adds selectedRows from useDiscoveredAssetsTable to disable the bulk "Add" action (and show a tooltip) when any selected asset lacks an assigned system; change aligns behavior with existing per-row/Add-all disabling logic.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

form.getFieldValue("execution_frequency") ===
MonitorFrequency.NOT_SCHEDULED
}
className="w-full"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by styling fix.

@speaker-ender speaker-ender self-requested a review February 11, 2026 17:44
Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

@jpople jpople added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit cc8c5b3 Feb 11, 2026
45 checks passed
@jpople jpople deleted the jpople/eng-2609/disable-add-web-monitor-resources branch February 11, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants