address flaky bulk add test

[gilluminate]

adds stub for Dataset to avoid 404 error from unstubbed request in the test

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Feb 10, 2026 6:34pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Feb 10, 2026 6:34pm

[greptile-apps]

Greptile Overview

Greptile Summary

This PR updates the Cypress E2E spec for bulk vendor add to stub the Dataset endpoint, preventing intermittent 404s from an unstubbed request during the test run.

The change stays localized to the admin-ui Cypress test suite and is intended to make the bulk add flow deterministic by ensuring all expected network calls are intercepted.

Confidence Score: 4/5

• Mostly safe to merge, but there are a couple of deterministic E2E-test flake risks from the new stubbing approach.
• Change is localized to a Cypress spec, but adding stubDatamap() inside the test introduces intercept/alias overlap (@getSystems) and the test doesn’t wait on @getDatamap, which can keep the test flaky and intermittently fail in CI.
• clients/admin-ui/cypress/e2e/systems/plus/bulk-vendor-add.cy.ts

Important Files Changed

Filename	Overview
clients/admin-ui/cypress/e2e/systems/plus/bulk-vendor-add.cy.ts	Adds an additional stub (via stubDatamap()) to reduce flakiness from an unstubbed Dataset/Datamap request; as written, the new stub introduces intercept alias overlap (@getSystems) and doesn’t wait on @getDatamap, which can keep the test flaky.

[greptile-apps]

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (2)

clients/admin-ui/cypress/e2e/systems/plus/bulk-vendor-add.cy.ts
No wait on datamap

stubDatamap() sets up @getDatamap, but this test never waits for it. Since the click triggers navigation to the datamap page (which immediately requests /api/v1/plus/datamap/*), the test can still be flaky because it only asserts the URL and may finish before the datamap request is served. Add a cy.wait("@getDatamap") (or another deterministic datamap-page assertion) after clicking Continue.

---

clients/admin-ui/cypress/e2e/systems/plus/bulk-vendor-add.cy.ts
Intercept alias overlap

stubDatamap() also defines a GET /api/v1/system intercept aliased as @getSystems. If this spec (or shared setup like stubSystemCrud() in beforeEach) already sets up @getSystems, calling stubDatamap() inside the test re-registers the intercept and can change which response gets used for later /api/v1/system calls. To keep behavior deterministic, avoid re-aliasing the same route here (either remove that intercept from stubDatamap for this test, or call stubDatamap() in beforeEach before any visits/calls).