Fix docs_check setuptools issue#7350
Conversation
Apply the same --no-build-isolation fix to docs nox sessions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile OverviewGreptile SummaryThis PR updates the docs nox sessions to avoid PEP517 build isolation issues by explicitly pinning The change is confined to Confidence Score: 4/5
Important Files Changed
|
| "/bin/bash", | ||
| "-c", | ||
| "pip install -e /fides && mkdocs build", | ||
| "pip install setuptools==80.10.2 && pip install --no-build-isolation -e /fides && mkdocs build", |
There was a problem hiding this comment.
Missing wheel/versioneer in container
docs_check installs only setuptools==80.10.2 before doing an editable install of /fides. But generate_docs() now explicitly installs wheel and versioneer-518 first (likely because the build needs them). Since docs_check runs the install inside the docs container, it can still fail there if wheel/versioneer-518 aren’t already present in the image. Consider matching the host install by installing all three (setuptools, wheel, versioneer-518) in the container command before pip install --no-build-isolation -e /fides.
Also appears as an inconsistency with generate_docs() at noxfiles/docs_nox.py:11-13.
Applies the same
--no-build-isolationfix to the docs nox sessions that was missing from PR #7347.