Skip to content

Fix docs_check setuptools issue#7350

Merged
adamsachs merged 1 commit intoasachs/pin-setuptoolsfrom
fix-docs-check-setuptools
Feb 9, 2026
Merged

Fix docs_check setuptools issue#7350
adamsachs merged 1 commit intoasachs/pin-setuptoolsfrom
fix-docs-check-setuptools

Conversation

@thabofletcher
Copy link
Copy Markdown
Contributor

Applies the same --no-build-isolation fix to the docs nox sessions that was missing from PR #7347.

Apply the same --no-build-isolation fix to docs nox sessions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 9, 2026 10:50pm
fides-privacy-center Ignored Ignored Feb 9, 2026 10:50pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 9, 2026

Greptile Overview

Greptile Summary

This PR updates the docs nox sessions to avoid PEP517 build isolation issues by explicitly pinning setuptools==80.10.2 (and installing wheel/versioneer-518) and installing the repo with pip --no-build-isolation before running the docs build steps.

The change is confined to noxfiles/docs_nox.py, affecting both local docs generation (generate_docs) and the dockerized CI-style docs build (docs_check).

Confidence Score: 4/5

  • This PR is low-risk and close to mergeable, but docs_check may still fail in the container due to missing build prerequisites.
  • Changes are small and targeted to docs build tooling. The main remaining concern is an inconsistency between the host generate_docs() prerequisites (setuptools/wheel/versioneer) and the dockerized docs_check prerequisites (setuptools only), which can reintroduce the original failure mode inside the container if those packages aren’t already present.
  • noxfiles/docs_nox.py

Important Files Changed

Filename Overview
noxfiles/docs_nox.py Pins setuptools/wheel/versioneer for docs generation and uses pip --no-build-isolation when installing the repo in generate_docs and in the docker-based docs_check session.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

"/bin/bash",
"-c",
"pip install -e /fides && mkdocs build",
"pip install setuptools==80.10.2 && pip install --no-build-isolation -e /fides && mkdocs build",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing wheel/versioneer in container

docs_check installs only setuptools==80.10.2 before doing an editable install of /fides. But generate_docs() now explicitly installs wheel and versioneer-518 first (likely because the build needs them). Since docs_check runs the install inside the docs container, it can still fail there if wheel/versioneer-518 aren’t already present in the image. Consider matching the host install by installing all three (setuptools, wheel, versioneer-518) in the container command before pip install --no-build-isolation -e /fides.

Also appears as an inconsistency with generate_docs() at noxfiles/docs_nox.py:11-13.

@adamsachs adamsachs merged commit 17801ac into asachs/pin-setuptools Feb 9, 2026
50 checks passed
@adamsachs adamsachs deleted the fix-docs-check-setuptools branch February 9, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants