Skip to content

Updating ruff(check) to also check for formatting changes#7342

Merged
galvana merged 1 commit intomainfrom
ruff-fix
Feb 7, 2026
Merged

Updating ruff(check) to also check for formatting changes#7342
galvana merged 1 commit intomainfrom
ruff-fix

Conversation

@galvana
Copy link
Copy Markdown
Contributor

@galvana galvana commented Feb 7, 2026

Description Of Changes

Updating ruff(check) to also check for formatting changes.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@galvana galvana requested a review from a team as a code owner February 7, 2026 03:30
@galvana galvana requested review from erosselli and removed request for a team February 7, 2026 03:30
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Feb 7, 2026 3:30am
fides-privacy-center Ignored Ignored Feb 7, 2026 3:30am

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 7, 2026

Greptile Overview

Greptile Summary

  • Updates the ruff nox session so RuffMode.CHECK runs ruff format --check before ruff check, causing CI to fail when formatting would change.
  • Includes minor codebase-wide formatting-only updates produced by Ruff formatting (line wrapping and signature formatting).
  • No functional changes beyond the CI lint/format enforcement behavior in noxfiles/ci_nox.py.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are limited to enforcing Ruff formatting checks in CI plus formatting-only rewrites in a few Python files; no behavioral logic changes were introduced in application code paths.
  • No files require special attention

Important Files Changed

Filename Overview
noxfiles/ci_nox.py In ruff CHECK mode, also runs ruff format --check before ruff check to fail CI on formatting drift.
src/fides/api/db/ctl_session.py Pure formatting change: wraps a long logger.info f-string across multiple lines; no behavior change.
src/fides/api/service/authentication/authentication_strategy_google_cloud_service_account.py Formatting-only changes (line wrapping) around helper signature and a ValueError message condition; behavior appears unchanged.
src/fides/api/util/saas_util.py Formatting-only change: collapses multiline function signature for find_unresolved_placeholders onto one line.
tests/ops/util/test_saas_util.py Formatting-only changes to tests for find_unresolved_placeholders (line wrapping/parentheses); assertions unchanged.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@galvana galvana changed the title Updting ruff(check) to also check for formatting changes Updating ruff(check) to also check for formatting changes Feb 7, 2026
@galvana galvana requested review from johnewart and thabofletcher and removed request for erosselli February 7, 2026 03:33
Copy link
Copy Markdown
Contributor

@thabofletcher thabofletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good catch that we weren't verifying formatting in CI, only running the linter.

@galvana galvana added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit 77c969a Feb 7, 2026
54 of 55 checks passed
@galvana galvana deleted the ruff-fix branch February 7, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants