Replace infrastructure scanner error page with ErrorPage component by gilluminate · Pull Request #7338 · ethyca/fides

gilluminate · 2026-02-06T22:06:35Z

Description Of Changes

Replace the Chakra-based ScannerError component with the shared Ant Design ErrorPage component across all infrastructure scanner forms. Migrate layout from Chakra (Stack, Box, HStack, Text) to Ant (Flex, Typography) and update toast notifications from useChakraToast to useMessage.

Code Changes

Added fullScreen prop to ErrorPage to support inline (non-full-screen) usage
Widened ErrorPage error prop to accept ParsedError in addition to RTK error types, with an isParsedError type guard
Updated defaultMessage handling so it takes priority over error.message for ParsedError when explicitly provided
Replaced ScannerError with ErrorPage in AuthenticateAwsForm, AuthenticateOktaForm, and LoadDataFlowScanner
Preserved AWS 403 permission-specific error handling with IAM documentation link in AuthenticateAwsForm
Migrated LoadDataFlowScanner from useChakraToast to useMessage
Added isRequired to Okta form fields that were missing it
Updated AWS region options to match current AWS documentation (added 12 new regions)
Removed broken documentation URL constants from constants.tsx
Deleted ScannerError.tsx

Steps to Confirm

Navigate to the Add systems page and select the AWS scanner flow (https://fides-plus-nightly-git-gill-eng-2533replace-infra-ddeb40-ethyca.vercel.app/add-systems)
Confirm the form renders correctly with all fields and Cancel/Save buttons
Submit invalid AWS credentials and confirm the error page displays inline with a Cancel button
Navigate to the Okta scanner flow and repeat similar validation

Pre-Merge Checklist

Issue requirements met
All CI pipelines succeeded
CHANGELOG.md updated
UX feedback:
- All UX related changes have been reviewed by a designer
- No UX review needed
Followup issues:
- No followup issues
Database migrations:
- No migrations
Documentation:
- No documentation updates required

vercel · 2026-02-06T22:06:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Feb 10, 2026 5:06pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Feb 10, 2026 5:06pm

greptile-apps · 2026-02-07T00:02:01Z

Greptile Overview

Greptile Summary

Replaces the config-wizard’s Chakra-based ScannerError with the shared Ant Design ErrorPage across AWS/Okta/data-flow scanner paths.
Updates AWS/Okta authentication forms to Ant Flex/Typography layout and tweaks form requirements (e.g., required flags, Okta scopes parsing).
Extends ErrorPage to support inline (non-full-screen) usage and to accept ParsedError in addition to RTK error types.
Updates Cypress E2E tests to assert against the new ErrorPage rendering.
Removes obsolete docs URL constants and expands AWS region options.

Confidence Score: 3/5

This PR is likely mergeable after addressing a few behavior/coverage issues in the wizard UI and request payload handling.
Core refactor is straightforward, but there are a couple of changes that can cause real user-facing problems (Okta scopes can include empty entries; wizard layout width constraint was removed) and one effect dependency that can duplicate success handling if useMessage() is unstable. Prior review threads also indicate ErrorPage type-guard/default-message logic may still be incorrect for some RTK error shapes.
clients/admin-ui/src/features/config-wizard/AuthenticateOktaForm.tsx, clients/admin-ui/src/features/config-wizard/AuthenticateScanner.tsx, clients/admin-ui/src/features/config-wizard/LoadDataFlowScanner.tsx, clients/admin-ui/src/features/common/errors/ErrorPage.tsx

Important Files Changed

Filename	Overview
changelog/7338.yaml	Adds changelog entry for replacing scanner error page with shared ErrorPage.
clients/admin-ui/cypress/e2e/config-wizard.cy.ts	Updates Cypress assertions to target ErrorPage; drops error-details assertions (coverage regression).
clients/admin-ui/src/features/common/errors/ErrorPage.tsx	Extends ErrorPage to accept ParsedError and adds fullScreen prop; prior review threads already flagged type-guard/defaultMessage behavior changes.
clients/admin-ui/src/features/config-wizard/AuthenticateAwsForm.tsx	Replaces ScannerError with inline ErrorPage and migrates layout to Ant Flex/Typography; preserves AWS 403 copy/link.
clients/admin-ui/src/features/config-wizard/AuthenticateOktaForm.tsx	Replaces ScannerError with ErrorPage and makes fields required; new scopes splitting can send empty scopes on trailing commas.
clients/admin-ui/src/features/config-wizard/AuthenticateScanner.tsx	Removes Chakra Box wrapper; changes step layout width constraints (likely visible behavior change).
clients/admin-ui/src/features/config-wizard/LoadDataFlowScanner.tsx	Migrates toast to useMessage and replaces ScannerError with ErrorPage; effect dependency on messageApi may cause duplicate success handling if unstable.
clients/admin-ui/src/features/config-wizard/ScannerError.tsx	Deletes legacy Chakra-based ScannerError component.
clients/admin-ui/src/features/config-wizard/constants.tsx	Removes unused/broken docs URL constants; expands AWS region options and tweaks step name casing.

greptile-apps

_{9 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

clients/admin-ui/src/features/common/errors/ErrorPage.tsx

gilluminate · 2026-02-07T00:08:33Z

@greptile

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-07T00:11:08Z

Additional Comments (1)

clients/admin-ui/src/features/config-wizard/AuthenticateOktaForm.tsx
scopes must be an array, but you're wrapping the string in an array. The split on comma in validation means values.scopes is still a string like "okta.apps.read, okta.users.read", so this creates [["okta.apps.read, okta.users.read"]] instead of ["okta.apps.read", "okta.users.read"]

      scopes: values.scopes ? values.scopes.split(",").map((s) => s.trim()) : ["okta.apps.read"],

gilluminate · 2026-02-07T00:15:29Z

@greptile

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

clients/admin-ui/src/features/common/errors/ErrorPage.tsx

gilluminate · 2026-02-07T00:21:20Z

@greptile

greptile-apps

_{9 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

clients/admin-ui/src/features/config-wizard/AuthenticateScanner.tsx

clients/admin-ui/src/features/config-wizard/AuthenticateOktaForm.tsx

clients/admin-ui/cypress/e2e/config-wizard.cy.ts

greptile-apps · 2026-02-07T00:23:46Z

Additional Comments (1)

clients/admin-ui/src/features/config-wizard/LoadDataFlowScanner.tsx
Duplicate success handling

This effect will run any time messageApi changes identity (since it’s in the dependency list). If useMessage() returns a non-stable object, this can re-fire for the same scanResults, resulting in duplicated success messages and repeated changeStep() dispatches.

Avoid depending on an unstable messageApi reference (e.g., extract a stable callback) so the success path is executed only once per scan completion.

speaker-ender

Approving because it seems to function as intended.
I do have a concern about some of the logic as noted in my comment.

clients/admin-ui/src/features/common/errors/ErrorPage.tsx

vercel bot deployed to Preview – fides-plus-nightly February 6, 2026 22:10 View deployment

gilluminate force-pushed the gill/ENG-2533/replace-infrastructure-scanner-error-page-with-new branch from c6f0efc to a4aeaad Compare February 6, 2026 22:11

vercel bot deployed to Preview – fides-plus-nightly February 6, 2026 23:18 View deployment

gilluminate force-pushed the gill/ENG-2533/replace-infrastructure-scanner-error-page-with-new branch from 970a2cb to c2ddebd Compare February 6, 2026 23:22

vercel bot deployed to Preview – fides-plus-nightly February 6, 2026 23:26 View deployment

gilluminate marked this pull request as ready for review February 6, 2026 23:59

gilluminate requested a review from a team as a code owner February 6, 2026 23:59

gilluminate requested review from speaker-ender and removed request for a team February 6, 2026 23:59

greptile-apps bot reviewed Feb 7, 2026

View reviewed changes

clients/admin-ui/src/features/common/errors/ErrorPage.tsx Outdated Show resolved Hide resolved

greptile-apps bot reviewed Feb 7, 2026

View reviewed changes

vercel bot deployed to Preview – fides-plus-nightly February 7, 2026 00:12 View deployment

greptile-apps bot reviewed Feb 7, 2026

View reviewed changes

clients/admin-ui/src/features/common/errors/ErrorPage.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – fides-plus-nightly February 7, 2026 00:18 View deployment

greptile-apps bot reviewed Feb 7, 2026

View reviewed changes

clients/admin-ui/src/features/config-wizard/AuthenticateScanner.tsx Show resolved Hide resolved

clients/admin-ui/src/features/config-wizard/AuthenticateOktaForm.tsx Show resolved Hide resolved

clients/admin-ui/cypress/e2e/config-wizard.cy.ts Show resolved Hide resolved

vercel bot deployed to Preview – fides-plus-nightly February 7, 2026 00:24 View deployment

speaker-ender approved these changes Feb 9, 2026

View reviewed changes

clients/admin-ui/src/features/common/errors/ErrorPage.tsx Outdated Show resolved Hide resolved

gilluminate added 6 commits February 10, 2026 10:01

Migrate scanner pages to Ant and replace Error

cf3bf42

Update ErrorPage.tsx

62f6ec7

restore cancel button

5931ead

restore 403 handling

e306e5f

remove old error component and old URL constants

aa7db04

update list to latest from AWS website

aa58d2e

gilluminate added 8 commits February 10, 2026 10:01

Dead Code / Misleading Props

198a683

nit pick fixes

7a04ea5

Create 7338.yaml

2bb0516

update tests

bbd583d

address fragility of parsed errors

ae2c843

PR feedback: fix to match validator

887be0c

Update ErrorPage.tsx

8d69846

Update ErrorPage.tsx

b9f08d1

gilluminate force-pushed the gill/ENG-2533/replace-infrastructure-scanner-error-page-with-new branch from 2982870 to b9f08d1 Compare February 10, 2026 17:01

vercel bot deployed to Preview – fides-plus-nightly February 10, 2026 17:06 View deployment

gilluminate added this pull request to the merge queue Feb 10, 2026

Merged via the queue into main with commit 22a3ba3 Feb 10, 2026
46 checks passed

gilluminate deleted the gill/ENG-2533/replace-infrastructure-scanner-error-page-with-new branch February 10, 2026 17:35

Conversation

gilluminate commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gilluminate commented Feb 7, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 7, 2026

Uh oh!

gilluminate commented Feb 7, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gilluminate commented Feb 7, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Feb 7, 2026

Uh oh!

speaker-ender left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gilluminate commented Feb 6, 2026 •

edited

Loading

vercel bot commented Feb 6, 2026 •

edited

Loading

greptile-apps bot commented Feb 7, 2026 •

edited

Loading