Skip to content

Okta monitor results UX fixes#7325

Merged
jpople merged 1 commit intomainfrom
jpople/eng-2528/okta-monitor-fixes
Feb 6, 2026
Merged

Okta monitor results UX fixes#7325
jpople merged 1 commit intomainfrom
jpople/eng-2528/okta-monitor-fixes

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Feb 5, 2026

Ticket ENG-2528

Description Of Changes

Fixes two UX bugs in the Okta monitor results view:

  • Restores mistakenly-removed "Ignored" tag on ignored system results
  • Switches bulk actions to use Ant Message component instead of Chakra toast

Steps to Confirm

  1. Create and run an Okta monitor and view the results
  2. Do some bulk actions on the results; should see Ant toast on action
  3. Set filter to "ignored", should see "ignored" tag next to result names

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner February 5, 2026 21:29
@jpople jpople requested review from lucanovera and removed request for a team February 5, 2026 21:29
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 5, 2026 9:37pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 5, 2026 9:37pm

Request Review

@jpople jpople force-pushed the jpople/eng-2528/okta-monitor-fixes branch from bf6efff to d21ac65 Compare February 5, 2026 21:32
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 5, 2026

Additional Comments (3)

clients/admin-ui/src/features/data-discovery-and-detection/action-center/tables/DiscoveredInfrastructureSystemsTable.tsx
Runtime error in ignored-tab check

isIgnoredTab: diffStatusFilters?.includes(DiffStatus.MUTED) will throw when diffStatusFilters is a single DiffStatus (string), because strings don’t have .includes for arrays in this sense and TS won’t protect at runtime. This can happen because useDiscoveredInfrastructureSystemsTable returns a single DiffStatus when only one status filter is selected. Consider normalizing to an array before calling .includes (or use Array.isArray).


clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useDiscoveredInfrastructureSystemsTable.tsx
Tab filtering is bypassed

diffStatusFilters currently defaults to [DiffStatus.ADDITION, DiffStatus.MUTED] whenever statusFilters is falsy or an empty array. Because useInfrastructureSystemsFilters.reset() sets statusFilters to [], and because the Action Center tabs are separate from these query-state filters, this makes the API request include both ADDITION+MUTED even when the user is on the "Added" tab (which expects MONITORED) or "Attention required" (expects ADDITION only). Result: tab views can show the wrong results whenever statusFilters is empty (including after reset). The default should come from the active tab’s activeParams.diff_status, not a hardcoded pair.


changelog/7312-okta-monitor-restore-action.yaml
Changelog PR number mismatch

This file is being added in PR #7325 but the changelog entry says pr: 7312. Our release tooling typically uses this field to link entries back to the originating PR; leaving this as-is will misattribute the change.

Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looks good!

@jpople jpople added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 061c018 Feb 6, 2026
45 of 46 checks passed
@jpople jpople deleted the jpople/eng-2528/okta-monitor-fixes branch February 6, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants