Implement multi-page "select all" for Okta monitor results by jpople · Pull Request #7307 · ethyca/fides

jpople · 2026-02-04T08:34:41Z

Description Of Changes

Implements multi-page select-all and bulk action functionality for Okta monitors.

Code Changes

Update bulk actions and selection hooks to add select-all
Update MSW mocks to return multi-page response for testing

Steps to Confirm

Probably easiest to test using the new mocks, so run npm run dev:mock (I ran into some strange issues trying to do this with Turbo, but maybe that's just my machine) to get a multi-page response

View Okta monitor results
Should see multiple pages of results if using the mock
Should be able to individually select results and take bulk actions
Should be able to "select all" and take bulk actions on every result across all pages
Should be able to individually deselect results and see them in the "excluded" field in a bulk action request body
Currently applied filters should show in all bulk action request bodies

Pre-Merge Checklist

vercel · 2026-02-04T08:34:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Feb 4, 2026 11:52pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Feb 4, 2026 11:52pm

greptile-apps · 2026-02-04T08:37:34Z

Greptile Overview

Greptile Summary

implements multi-page "select all" functionality for Okta monitor results with two selection modes: explicit (individual selections) and all (select everything with exclusions)

Key Changes:

adds selectionMode state that switches between explicit selection and "select all" mode
tracks excluded items by URN when in "all" mode to support deselection
filters are passed to backend for bulk actions, allowing server-side filtering
selection automatically clears when filters change to prevent stale selections
adds 150 mock infrastructure systems for multi-page testing

Issues Found:

inconsistent request body format between bulk-promote (wraps urns in object) and bulk-mute/bulk-unmute (sends urns directly) in discovery-detection.slice.ts:419-436
significant code duplication in mock handlers - the filter application logic is repeated identically across three bulk action handlers (handlers.ts:197-430)

Confidence Score: 3/5

safe to merge after fixing the request body format inconsistency in bulk-promote
the logic inconsistency in the slice file could cause the bulk-promote endpoint to fail when using the explicit mode with urns, as the backend likely expects the same format across all three endpoints
pay close attention to discovery-detection.slice.ts for the request body format issue, and consider refactoring handlers.ts to reduce duplication

Important Files Changed

Filename	Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useInfrastructureSystemsSelection.tsx	adds multi-page select-all logic with two modes (explicit/all) and URN-based exclusion tracking, clears selection on filter changes
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useInfrastructureSystemsBulkActions.tsx	adds support for filter-based bulk actions with exclusions, extracts count from backend response summary
clients/admin-ui/src/features/data-discovery-and-detection/discovery-detection.slice.ts	adds bulkSelection parameter to bulk action mutations with filters and exclude_urns, has inconsistent request body format
clients/admin-ui/src/mocks/action-center/handlers.ts	adds MSW handlers for filters and bulk actions with significant code duplication across handlers

greptile-apps

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

clients/admin-ui/src/mocks/action-center/handlers.ts

clients/admin-ui/src/features/data-discovery-and-detection/discovery-detection.slice.ts

speaker-ender

Tested locally and works as expected.
Minor nits and questions

speaker-ender · 2026-02-04T20:17:19Z

clients/admin-ui/src/features/data-discovery-and-detection/discovery-detection.slice.ts

-        url: `/plus/identity-provider-monitors/${monitor_config_key}/results/bulk-mute`,
-        body: urns,
-      }),
+      query: ({ monitor_config_key, urns, bulkSelection }) => {


Is there a reason why passing both args is disallowed?

The backend will error if both are provided and nonempty so I preferred enforcing that here. Technically the UI shouldn't ever be in a state where we have a value for both, but if the selection itself is working correctly it shouldn't cause any harm, if you think just passing both is better.

Oof that's not good api design imo bc there is not way to know that without looking at comments in the docs (if they even exist).
I'm fine with leaving as is to help reduce invalid queries but I'd add some comments about why.
Alternatively you could make a discriminated union type that would disallow certain combinations of filters lol.

speaker-ender · 2026-02-04T20:18:21Z

clients/admin-ui/src/features/data-discovery-and-detection/discovery-detection.slice.ts

+  bulkSelection?: {
+    filters?: {
+      search?: string;
+      diff_status?: DiffStatus | DiffStatus[];
+      vendor_id?: string | string[];
+      data_uses?: string[];
+    };
+    exclude_urns?: string[];
+  };


Is there a need to abstract part of the raw filters?

Yeah, good callout-- I've made a new type for these filter values and applied it to other areas where they're used.

speaker-ender · 2026-02-04T20:43:45Z

...tures/data-discovery-and-detection/action-center/hooks/useInfrastructureSystemsSelection.tsx

+    excludedKeys,
+    excludedUrns,
+    selectionMode,


Is there a reason why the useBulkListSelect hook wasn't able to work here? (I realize this hook wasn't added in the PR)

I messed with this a good bit and it seems impractical to integrate useBulkListSelect with the existing custom selection hook. I think it could probably be rewritten to use useBulkListSelect directly and obviate the custom hook entirely but it'd be a larger undertaking and I'd rather not let that block merging at this point.

jpople added 7 commits February 2, 2026 13:20

robot

4138de4

code cleanup

559cb8f

swap order of 'Add' and 'Ignore' bulk actions

9c65d90

Merge branch 'main' into jpople/eng-2222/okta-monitor-select-all

eb17a4a

lint fixes

d731a66

update mocks for testing

b2e03dd

format

8af126d

jpople requested a review from a team as a code owner February 4, 2026 08:34

jpople requested review from lucanovera and removed request for a team February 4, 2026 08:34

vercel bot deployed to Preview – fides-plus-nightly February 4, 2026 08:36 View deployment

greptile-apps bot reviewed Feb 4, 2026

View reviewed changes

clients/admin-ui/src/mocks/action-center/handlers.ts Show resolved Hide resolved

clients/admin-ui/src/features/data-discovery-and-detection/discovery-detection.slice.ts Outdated Show resolved Hide resolved

jpople added 3 commits February 4, 2026 13:23

helper for mocks

8de2cc8

changelog

888908c

Merge branch 'main' into jpople/eng-2222/okta-monitor-select-all

1fe88e6

speaker-ender approved these changes Feb 4, 2026

View reviewed changes

PR feedback

be4a0e5

vercel bot deployed to Preview – fides-plus-nightly February 4, 2026 23:44 View deployment

Merge branch 'main' into jpople/eng-2222/okta-monitor-select-all

11a5e46

vercel bot deployed to Preview – fides-plus-nightly February 4, 2026 23:52 View deployment

jpople added this pull request to the merge queue Feb 5, 2026

Merged via the queue into main with commit 8dbb35a Feb 5, 2026
45 of 46 checks passed

jpople deleted the jpople/eng-2222/okta-monitor-select-all branch February 5, 2026 14:41

greptile-apps bot mentioned this pull request Feb 6, 2026

2.78.2 changelog update #7333

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement multi-page "select all" for Okta monitor results#7307

Implement multi-page "select all" for Okta monitor results#7307
jpople merged 12 commits intomainfrom
jpople/eng-2222/okta-monitor-select-all

jpople commented Feb 4, 2026 •

edited by atlassian bot

Loading

Uh oh!

vercel bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Feb 4, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

speaker-ender left a comment

Uh oh!

speaker-ender Feb 4, 2026

Uh oh!

jpople Feb 4, 2026

Uh oh!

speaker-ender Feb 4, 2026

Uh oh!

speaker-ender Feb 4, 2026

Uh oh!

jpople Feb 4, 2026

Uh oh!

speaker-ender Feb 4, 2026

Uh oh!

jpople Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jpople commented Feb 4, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Feb 4, 2026

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

speaker-ender left a comment

Choose a reason for hiding this comment

Uh oh!

speaker-ender Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

jpople Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

jpople Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

jpople Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpople commented Feb 4, 2026 •

edited by atlassian bot

Loading

vercel bot commented Feb 4, 2026 •

edited

Loading