Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Author
Contributor
Greptile OverviewGreptile SummaryThis PR fixes a bug in the Snowflake connector where private keys without a passphrase were not being properly converted to DER/PKCS8 format, causing authentication failures. Key Changes:
Analysis: Confidence Score: 5/5
Important Files Changed
|
wadesdev
approved these changes
Feb 2, 2026
adamsachs
approved these changes
Feb 3, 2026
vcruces
added a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2494
Description Of Changes
Fixed a bug in the Snowflake connector where private keys without a passphrase were not being properly converted to the DER/PKCS8 format required by Snowflake. Previously, the code only performed this conversion when a passphrase was present, causing connection failures with the error "Failed to load private key: Could not deserialize key data."
Code Changes
SnowflakeConnector.get_connect_args()to always convert private keys to DER/PKCS8 format regardless of whether a passphrase is presentSteps to Confirm
GET /api/v1/connection/{connection_key}/testPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works