Update Okta monitor infrastructure systems filters#7289
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Greptile OverviewGreptile SummaryThis PR refactors the Okta monitor infrastructure systems filtering UX. The filter dropdown now consolidates status and vendor filtering into 4 clear options (New, Known systems, Unknown systems, Ignored) instead of separate dropdowns. The "New" filter is now the default on page load. Key changes:
Technical implementation:
Confidence Score: 4/5
Important Files Changed
|
speaker-ender
approved these changes
Feb 4, 2026
Contributor
speaker-ender
left a comment
There was a problem hiding this comment.
Minor nit but looks good!
| } | ||
| const { diffStatusFilter, vendorIdFilter } = | ||
| INFRASTRUCTURE_STATUS_FILTER_MAP[ | ||
| value as InfrastructureStatusFilterOptionValue |
Contributor
There was a problem hiding this comment.
Can we do a find on the values rather than a type cast with an indexed lookup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2480
Description Of Changes
Updated UX for filtering Okta monitor results. "Type" and "Status" are now a single filter which has 4 options:
diff_statusof "addition"); this is now the default view on page loadSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works