Skip to content

Update Okta monitor infrastructure systems filters#7289

Merged
jpople merged 14 commits intomainfrom
jpople/eng-2480/okta-monitor-filters-update
Feb 4, 2026
Merged

Update Okta monitor infrastructure systems filters#7289
jpople merged 14 commits intomainfrom
jpople/eng-2480/okta-monitor-filters-update

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Feb 2, 2026

Ticket ENG-2480

Description Of Changes

Updated UX for filtering Okta monitor results. "Type" and "Status" are now a single filter which has 4 options:

  • "New": shows all new results (i.e. results with a diff_status of "addition"); this is now the default view on page load
  • "Known": shows new results with known systems
  • "Unknown": shows new results with unknown systems
  • "Ignored": shows ignored results

Steps to Confirm

  1. Create and run an Okta monitor
  2. View the monitor's results in the action center
  3. Verify that filters default to "New" status on initial load
  4. Test each filter option (New, Known systems, Unknown systems, Ignored) and verify correct filtering
  5. Verify that filter state persists in URL query parameters

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 4, 2026 7:54pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 4, 2026 7:54pm

Request Review

@jpople jpople marked this pull request as ready for review February 2, 2026 18:42
@jpople jpople requested a review from a team as a code owner February 2, 2026 18:42
@jpople jpople requested review from speaker-ender and removed request for a team February 2, 2026 18:42
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 2, 2026

Greptile Overview

Greptile Summary

This PR refactors the Okta monitor infrastructure systems filtering UX. The filter dropdown now consolidates status and vendor filtering into 4 clear options (New, Known systems, Unknown systems, Ignored) instead of separate dropdowns. The "New" filter is now the default on page load.

Key changes:

  • Simplified filter UI by combining status and vendor filters into a single dropdown with 4 semantic options
  • Set default filter to "New" (DiffStatus.ADDITION) on initial load
  • Removed duplicate tagRender function by importing from shared location
  • Added comprehensive test coverage for filter parsing logic
  • Implemented proper handling for cleared filters (shows addition + muted, excluding reviewed results)
  • Moved InfrastructureSystemsFilters component from fields/ to components/ directory

Technical implementation:

  • INFRASTRUCTURE_STATUS_FILTER_MAP maps UI options to their underlying diffStatusFilter and vendorIdFilter values
  • parseFiltersToFilterValue reverses this mapping to display the correct UI state
  • Filter state persists in URL query parameters via nuqs

Confidence Score: 4/5

  • This PR is safe to merge with one minor fix needed (missing PR number in changelog)
  • The implementation is clean and well-tested. The refactoring consolidates duplicate code and adds good test coverage. Only issue is a missing PR number in one changelog file.
  • changelog/eng-2479-add-data-uses-to-okta-results.yaml needs PR number added

Important Files Changed

Filename Overview
changelog/eng-2479-add-data-uses-to-okta-results.yaml New changelog entry for data uses functionality; missing PR number
clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemsFilters.tsx Refactored filters with new 4-option status dropdown (New, Known, Unknown, Ignored) and removed standalone Type filter
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/utils.ts Added filter mapping logic with INFRASTRUCTURE_STATUS_FILTER_MAP and parseFiltersToFilterValue function
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useDiscoveredInfrastructureSystemsTable.tsx Updated filter transformation logic to handle new 4-option filter system with proper empty-state handling

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but looks good!

}
const { diffStatusFilter, vendorIdFilter } =
INFRASTRUCTURE_STATUS_FILTER_MAP[
value as InfrastructureStatusFilterOptionValue
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do a find on the values rather than a type cast with an indexed lookup?

@jpople jpople enabled auto-merge February 4, 2026 19:53
@jpople jpople added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit ba20d8c Feb 4, 2026
46 checks passed
@jpople jpople deleted the jpople/eng-2480/okta-monitor-filters-update branch February 4, 2026 20:15
@greptile-apps greptile-apps bot mentioned this pull request Feb 6, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants