Skip to content

update Python version in docs#7288

Merged
gilluminate merged 1 commit intomainfrom
update-Python-version-in-documentation
Feb 2, 2026
Merged

update Python version in docs#7288
gilluminate merged 1 commit intomainfrom
update-Python-version-in-documentation

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

Updates README documentation and comments only. No functionality changes

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 2, 2026 5:43pm
fides-privacy-center Ignored Ignored Feb 2, 2026 5:43pm

Request Review

@gilluminate gilluminate force-pushed the update-Python-version-in-documentation branch from 240c988 to 41889a4 Compare February 2, 2026 17:43
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 2, 2026

Greptile Overview

Greptile Summary

This PR updates Python version documentation from 3.9-3.10 to 3.13 only, updates Twitter references to X, and simplifies a pip installation comment. However, there's a critical inconsistency: the documentation now states "(version 3.13)" which implies Python 3.13 is the only supported version, but setup.py line 65 specifies python_requires=">=3.9, <4" which means the package actually supports Python 3.9 and later.

Key changes:

  • Changed Python requirement from "3.9 through 3.10" to "3.13" in README and developer docs
  • Updated social media link from Twitter to X
  • Simplified comment from pip3.10 install to pip install in git_nox.py

Issue found:

  • The documentation creates a misleading requirement that could prevent users with valid Python 3.9-3.12 installations from attempting to use Fides, even though the package would work fine for them. The documentation should accurately reflect the minimum supported version (3.9+) while recommending the latest tested version (3.13).

Confidence Score: 2/5

  • This PR has documentation inconsistencies that will mislead users about Python version requirements
  • While the changes are documentation-only and won't break functionality, they introduce misleading information that contradicts the actual package requirements. Users with Python 3.9-3.12 might incorrectly believe they cannot use Fides when the package actually supports their versions. This discrepancy between documentation and code needs to be resolved before merging.
  • README.md and docs/fides/docs/development/overview.md both need Python version requirements corrected to reflect actual package support

Important Files Changed

Filename Overview
README.md Updated Python version requirement to 3.13, but conflicts with setup.py which allows 3.9+; also changed Twitter to X
docs/fides/docs/development/overview.md Updated Python version requirement to 3.13, but conflicts with package's actual minimum requirement of 3.9+

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile


* [Docker](https://www.docker.com/products/docker-desktop) (version 20.10.11 or later)
* [Python](https://www.python.org/downloads/) (version 3.9 through 3.10)
* [Python](https://www.python.org/downloads/) (version 3.13)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation states "(version 3.13)" which implies ONLY Python 3.13 is supported, but setup.py:65 shows python_requires=">=3.9, <4" which allows Python 3.9+. This creates a misleading requirement that could prevent users with valid Python versions from using Fides.

Suggested change
* [Python](https://www.python.org/downloads/) (version 3.13)
* [Python](https://www.python.org/downloads/) (version 3.9 or later, 3.13 recommended)


* __Docker Desktop (version 20.10.11 or later)__ - [Docker Desktop Download Page](https://www.docker.com/products/docker-desktop/)
* __Python (version 3.9 through 3.10)__ - To simplify the installation experience and create a more stable Python installation that can be managed indepently, we recommend installing Python via Anaconda. The installer for Anaconda can be found [here](https://www.anaconda.com/download).
* __Python (version 3.13)__ - To simplify the installation experience and create a more stable Python installation that can be managed indepently, we recommend installing Python via Anaconda. The installer for Anaconda can be found [here](https://www.anaconda.com/download).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue - documentation states "(version 3.13)" which implies ONLY Python 3.13 is supported, but the actual package accepts Python 3.9+

Suggested change
* __Python (version 3.13)__ - To simplify the installation experience and create a more stable Python installation that can be managed indepently, we recommend installing Python via Anaconda. The installer for Anaconda can be found [here](https://www.anaconda.com/download).
* __Python (version 3.9 or later, 3.13 recommended)__ - To simplify the installation experience and create a more stable Python installation that can be managed indepently, we recommend installing Python via Anaconda. The installer for Anaconda can be found [here](https://www.anaconda.com/download).

Copy link
Copy Markdown
Collaborator

@johnewart johnewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gilluminate gilluminate enabled auto-merge February 2, 2026 17:53
@gilluminate gilluminate added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit e5357c0 Feb 2, 2026
54 of 55 checks passed
@gilluminate gilluminate deleted the update-Python-version-in-documentation branch February 2, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants