Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
240c988 to
41889a4
Compare
Greptile OverviewGreptile SummaryThis PR updates Python version documentation from 3.9-3.10 to 3.13 only, updates Twitter references to X, and simplifies a pip installation comment. However, there's a critical inconsistency: the documentation now states "(version 3.13)" which implies Python 3.13 is the only supported version, but Key changes:
Issue found:
Confidence Score: 2/5
Important Files Changed
|
|
|
||
| * [Docker](https://www.docker.com/products/docker-desktop) (version 20.10.11 or later) | ||
| * [Python](https://www.python.org/downloads/) (version 3.9 through 3.10) | ||
| * [Python](https://www.python.org/downloads/) (version 3.13) |
There was a problem hiding this comment.
Documentation states "(version 3.13)" which implies ONLY Python 3.13 is supported, but setup.py:65 shows python_requires=">=3.9, <4" which allows Python 3.9+. This creates a misleading requirement that could prevent users with valid Python versions from using Fides.
| * [Python](https://www.python.org/downloads/) (version 3.13) | |
| * [Python](https://www.python.org/downloads/) (version 3.9 or later, 3.13 recommended) |
|
|
||
| * __Docker Desktop (version 20.10.11 or later)__ - [Docker Desktop Download Page](https://www.docker.com/products/docker-desktop/) | ||
| * __Python (version 3.9 through 3.10)__ - To simplify the installation experience and create a more stable Python installation that can be managed indepently, we recommend installing Python via Anaconda. The installer for Anaconda can be found [here](https://www.anaconda.com/download). | ||
| * __Python (version 3.13)__ - To simplify the installation experience and create a more stable Python installation that can be managed indepently, we recommend installing Python via Anaconda. The installer for Anaconda can be found [here](https://www.anaconda.com/download). |
There was a problem hiding this comment.
Same issue - documentation states "(version 3.13)" which implies ONLY Python 3.13 is supported, but the actual package accepts Python 3.9+
| * __Python (version 3.13)__ - To simplify the installation experience and create a more stable Python installation that can be managed indepently, we recommend installing Python via Anaconda. The installer for Anaconda can be found [here](https://www.anaconda.com/download). | |
| * __Python (version 3.9 or later, 3.13 recommended)__ - To simplify the installation experience and create a more stable Python installation that can be managed indepently, we recommend installing Python via Anaconda. The installer for Anaconda can be found [here](https://www.anaconda.com/download). |
Updates README documentation and comments only. No functionality changes