Skip to content

Add data uses modification to Okta monitor results [ENG-2479]#7280

Merged
jpople merged 8 commits intomainfrom
jpople/eng-2479/add-data-uses-to-okta-results
Feb 2, 2026
Merged

Add data uses modification to Okta monitor results [ENG-2479]#7280
jpople merged 8 commits intomainfrom
jpople/eng-2479/add-data-uses-to-okta-results

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Jan 30, 2026

Ticket ENG-2479

Description Of Changes

Added functionality to modify data uses for Okta identity provider monitor results in the infrastructure systems list.

Code Changes

  • Removed unused `onSetDataUses` and `onSelectDataUse` props in favor of accessing the mutation directly in the component

Steps to Confirm

  1. Run an Okta monitor
  2. View the results
  3. Verify that data uses can be added using the classification select and removed by clicking the X
  4. Verify that auto-detected data uses (from Compass) show a sparkle icon

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • `CHANGELOG.md` updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on `main`
    • Ensure that your `downgrade()` migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required"

@jpople jpople requested a review from a team as a code owner January 30, 2026 20:12
@jpople jpople requested review from gilluminate and removed request for a team January 30, 2026 20:12
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 30, 2026 10:00pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Jan 30, 2026 10:00pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

This PR adds data use modification functionality to Okta identity provider monitor results in the infrastructure systems list. The implementation refactors the InfrastructureSystemListItem component by removing the onSetDataUses and onSelectDataUse props and instead accessing the useUpdateInfrastructureSystemDataUsesMutation hook directly within the component.

Key Changes:

  • Refactored data use management to use mutation hook directly in the component
  • Added proper error handling using message API to display server errors
  • Removed prop drilling by managing data use updates locally
  • Added comprehensive Cypress test coverage for add, remove, error handling, duplicate prevention, and edge cases
  • Created test fixtures and stub helpers for infrastructure systems testing

Testing:
The PR includes thorough test coverage with 5 new test cases covering:

  • Adding data uses to infrastructure systems
  • Removing data uses from infrastructure systems
  • Error handling when updates fail
  • Preventing duplicate data use additions
  • Removing the last data use (edge case)

The refactoring improves code organization by eliminating unnecessary prop drilling while maintaining the existing functionality. The mutation already has proper invalidatesTags configuration to refresh data after updates.

Confidence Score: 5/5

  • This PR is safe to merge with no significant risks
  • The changes are well-structured and thoroughly tested. The refactoring simplifies the component by removing prop drilling, the mutation hook already has proper cache invalidation, error handling is implemented correctly, and comprehensive test coverage validates all scenarios including edge cases.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx Refactored to use mutation hook directly, removing onSetDataUses and onSelectDataUse props in favor of local data use management with proper error handling
clients/admin-ui/cypress/e2e/action-center/infrastructure-systems.cy.ts Added comprehensive test coverage for data use management including add, remove, error handling, duplicate prevention, and edge cases

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@jpople jpople added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit f25bc8d Feb 2, 2026
46 checks passed
@jpople jpople deleted the jpople/eng-2479/add-data-uses-to-okta-results branch February 2, 2026 17:24
@greptile-apps greptile-apps bot mentioned this pull request Feb 6, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants