Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Greptile OverviewGreptile SummaryThis PR adds bidirectional URL-to-form synchronization for the monitor list search form. Previously, form changes updated the URL, but URL changes (from browser navigation or direct URL manipulation) didn't update the form. Key changes:
Impact:
The implementation leverages Ant Design's behavior where Confidence Score: 4/5
Important Files Changed
|
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useSearchForm.ts
Show resolved
Hide resolved
Updated description to include removal of default monitor filter.
adamsachs
approved these changes
Jan 30, 2026
Contributor
adamsachs
left a comment
There was a problem hiding this comment.
functionally this looks good, approving since we want to patch this bug and default behavior ASAP - we'll be coming back to this bit of code so a further review can be done then!
speaker-ender
added a commit
that referenced
this pull request
Jan 30, 2026
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2469
Description Of Changes
Allowing the search form to be updated by the url via an effect
Also removes default steward filter for current user
Code Changes
Steps to Confirm
Activity Centerlink in the navPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works