batch emails now check for action types#7271
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
added 2 commits
January 29, 2026 12:09
Contributor
Greptile OverviewGreptile SummaryFixed a bug where consent/erasure DSRs were checking all email connectors regardless of policy action types, which caused errors when irrelevant connectors were misconfigured. The
The fix includes a comprehensive regression test that verifies misconfigured connectors of the wrong type don't cause errors. Confidence Score: 5/5
Important Files Changed
|
tests/ops/service/privacy_request/test_request_runner_service.py
Outdated
Show resolved
Hide resolved
added 2 commits
January 29, 2026 12:57
Contributor
Author
|
@greptile please review |
erosselli
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
if this is going into the release, update the changelog.md directly :) since it's already been created
JadeCara
added a commit
that referenced
this pull request
Jan 29, 2026
Co-authored-by: Jade Wibbels <jade@ethyca.com>
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2467
Description Of Changes
When consent DSRs run they still check all of the erasure email connection configs which can cause errors unrelated to consent requests.
Additionally if a consent request has multiple rules ie consent and erasure it will only send the erasure email regardless of how the config/toggles are set.
Code Changes
src/fides/api/service/request_runner_service.py- Optimized needs_batch_email_send() to only check connectors relevant to the policy's action typestest_request_runner_service.py- Added regression test to prevent future issuesSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works