Skip to content

add bulk finalize functionality to the UI#7264

Merged
Kelsey-Ethyca merged 5 commits intomainfrom
ENG-1734-FE-Add-bulk-finalize-action-to-request-page
Jan 29, 2026
Merged

add bulk finalize functionality to the UI#7264
Kelsey-Ethyca merged 5 commits intomainfrom
ENG-1734-FE-Add-bulk-finalize-action-to-request-page

Conversation

@Kelsey-Ethyca
Copy link
Copy Markdown
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Jan 28, 2026

Ticket ENG-1734

Description Of Changes

Added bulk finalize action to the privacy request page, allowing users to finalize multiple requests that are in the "Requires manual finalization" status at once.

Code Changes

  • Added FINALIZE action type to BulkActionType enum in helpers.ts
  • Added FINALIZE to available actions for REQUIRES_MANUAL_FINALIZATION status
  • Added bulkFinalizeRequest mutation to privacy-requests.slice.ts
  • Added finalize action handling to usePrivacyRequestBulkActions hook including action config, mutation call, and menu item

Steps to Confirm

  1. Add [execution] section to .fides/fides.toml with erasure_request_finalization_required = true
  2. Start the dev environment and create an erasure privacy request
  3. Process the request until it reaches "Requires finalization" status
  4. Select one or more requests in the "Requires finalization" status
  5. Open the bulk actions dropdown and verify "Finalize" option is available
  6. Click "Finalize" and confirm the action
  7. Verify the requests are updated to "Complete" status

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • UX feedback:
    • No UX review needed
  • Followup issues:
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 28, 2026 7:26pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 28, 2026 7:26pm

Request Review

@Kelsey-Ethyca Kelsey-Ethyca marked this pull request as ready for review January 28, 2026 19:22
@Kelsey-Ethyca Kelsey-Ethyca requested a review from a team as a code owner January 28, 2026 19:22
@Kelsey-Ethyca Kelsey-Ethyca requested review from gilluminate and removed request for a team January 28, 2026 19:22
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 28, 2026

Greptile Overview

Greptile Summary

This PR adds bulk finalize functionality to the privacy request UI, allowing users to finalize multiple requests in REQUIRES_MANUAL_FINALIZATION status at once.

Key changes:

  • Added FINALIZE action type to BulkActionType enum
  • Added finalize action mapping to REQUIRES_MANUAL_FINALIZATION status in the readonly status-to-actions map
  • Created bulkFinalizeRequest mutation with proper cache invalidation
  • Integrated finalize action into the bulk actions menu with proper disabled state handling
  • Added comprehensive test coverage for the new functionality

Quality:

  • Follows existing patterns consistently (action configs, error handling, confirmation modals)
  • Includes proper test coverage for both the helper functions and the React hook
  • Uses the readonly mapping pattern as recommended by custom rules
  • Properly integrates with RTK Query cache invalidation

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The implementation is straightforward, follows existing patterns consistently, includes comprehensive test coverage, and only adds functionality without modifying existing behavior. The backend endpoint already exists, so this is purely a frontend integration.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/privacy-requests/helpers.ts Added FINALIZE bulk action type and mapped it to REQUIRES_MANUAL_FINALIZATION status
clients/admin-ui/src/features/privacy-requests/privacy-requests.slice.ts Added bulkFinalizeRequest mutation with proper invalidatesTags configuration
clients/admin-ui/src/features/privacy-requests/dashboard/hooks/usePrivacyRequestBulkActions.tsx Integrated finalize action into bulk actions hook with confirmation modal and error handling

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code and functionality both looking good.

@gilluminate gilluminate removed their request for review January 28, 2026 21:38
@Kelsey-Ethyca Kelsey-Ethyca added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit 12f312e Jan 29, 2026
46 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the ENG-1734-FE-Add-bulk-finalize-action-to-request-page branch January 29, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants