Skip to content

feat: action center empty state [ENG-2255]#7262

Merged
speaker-ender merged 3 commits intomainfrom
feat/action-center-empty-state--ENG-2255
Jan 28, 2026
Merged

feat: action center empty state [ENG-2255]#7262
speaker-ender merged 3 commits intomainfrom
feat/action-center-empty-state--ENG-2255

Conversation

@speaker-ender
Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender commented Jan 28, 2026

Ticket ENG-2255

Description Of Changes

Updating the monitor list empty component with new copy and visuals

Code Changes

  • Modifying the EmptyMonitorsResult component to reflect the new design and copy

Steps to Confirm

  1. Visit the action center
  2. Enter text into the search input that returns no results
  3. Confirm that the visual and text matches the mock up

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 28, 2026 9:42pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 28, 2026 9:42pm

Request Review

@speaker-ender speaker-ender marked this pull request as ready for review January 28, 2026 01:53
@speaker-ender speaker-ender requested a review from a team as a code owner January 28, 2026 01:53
@speaker-ender speaker-ender requested review from lucanovera and removed request for a team January 28, 2026 01:53
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 28, 2026

Greptile Overview

Greptile Summary

This PR updates the action center empty state with new visuals and copy. The component now fetches the user's systems to display a personalized message showing which systems they're stewarding.

Key changes:

  • Added new SVG assets (generic.svg, service.svg) for enhanced visual design
  • Component now fetches systems data using useGetSystemsQuery to display personalized steward information
  • Replaced simple empty state with elaborate visual showing connector icons arranged around a "Monitors" label
  • Updated copy from generic "all caught up" message to specific "Nothing To Review" with detailed explanation
  • Changed CTA from "Visit integrations" to "View inventory" with updated route

Issues found:

  • Critical logic bug in partitionLast function that fails for single-element arrays
  • String joining logic is overly complex and hard to read
  • Multiple div elements used where semantic HTML or Ant Design components would be preferred per project guidelines

Confidence Score: 2/5

  • Not safe to merge due to critical logic bug in partition function
  • The partitionLast function contains a logic error that will cause incorrect behavior when the systems array has exactly one element, leading to display issues in the UI. This bug needs to be fixed before merging.
  • clients/admin-ui/src/features/data-discovery-and-detection/action-center/EmptyMonitorsResult.tsx requires attention for the partition logic bug

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/EmptyMonitorsResult.tsx Enhanced empty state with data fetching and system display logic; contains partition logic bug

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit d24f44b Jan 28, 2026
46 checks passed
@speaker-ender speaker-ender deleted the feat/action-center-empty-state--ENG-2255 branch January 28, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants