Skip to content

Update infrastructure monitor results label#7260

Merged
lucanovera merged 6 commits intomainfrom
ENG-2389-FE-Replace-system-type-with-status-in-monitor-results-listing
Jan 28, 2026
Merged

Update infrastructure monitor results label#7260
lucanovera merged 6 commits intomainfrom
ENG-2389-FE-Replace-system-type-with-status-in-monitor-results-listing

Conversation

@lucanovera
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera commented Jan 28, 2026

Ticket ENG-2389

Description Of Changes

Replaced the "System type" label with a diff status tag in the infrastructure results view.

Code Changes

  • Add diff status mappings for infrastructure monitors
  • Replace system type with diff status tag using label and color mappings

Steps to Confirm

  1. Go to the action center and review monitor results for an Okta monitor
  2. In the results list check that next to the system title a tag is shown that shows the resource status (like "New")

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Jan 28, 2026 6:30pm
fides-privacy-center Ignored Ignored Jan 28, 2026 6:30pm

Request Review

@lucanovera lucanovera marked this pull request as ready for review January 28, 2026 01:05
@lucanovera lucanovera requested a review from a team as a code owner January 28, 2026 01:05
@lucanovera lucanovera requested review from gilluminate and removed request for a team January 28, 2026 01:05
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 28, 2026

Greptile Overview

Greptile Summary

This PR replaces the "System type" label with a diff status tag in the infrastructure results view. The change enhances the UI by displaying resource status (like "New", "Removed", "Approved", "Ignored") instead of generic system type information.

Key changes:

  • Replaced systemType display with conditional rendering of diff status tag
  • Added INFRASTRUCTURE_DIFF_STATUS_LABEL and INFRASTRUCTURE_DIFF_STATUS_COLOR mappings
  • Used destructuring to extract diff_status from the item

Issues found:

  • Invalid empty string for gap prop on line 172 - should be a valid spacing value or omitted
  • New status mappings duplicate existing logic in MAP_DIFF_STATUS_TO_RESOURCE_STATUS_LABEL

Confidence Score: 3/5

  • Safe to merge with minor fixes
  • The PR implements a straightforward UI enhancement with clear intent, but has a syntax error (empty gap prop) that needs fixing and introduces code duplication that could be refactored
  • Pay attention to InfrastructureSystemListItem.tsx for the gap prop fix

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx Replaces system type label with diff status tag, but has invalid empty gap prop
clients/admin-ui/src/features/data-discovery-and-detection/action-center/constants.ts Adds new status mappings that duplicate existing MAP_DIFF_STATUS_TO_RESOURCE_STATUS_LABEL

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@lucanovera lucanovera requested review from jpople and removed request for gilluminate January 28, 2026 01:51
…ion-center/components/InfrastructureSystemListItem.tsx

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, new labelling is working as expected.

@lucanovera lucanovera added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit be8afbe Jan 28, 2026
46 checks passed
@lucanovera lucanovera deleted the ENG-2389-FE-Replace-system-type-with-status-in-monitor-results-listing branch January 28, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants