Skip to content

[ENG-2393] Use discovery_monitor endpoint for Okta monitor filtering#7256

Merged
dsill-ethyca merged 5 commits intomainfrom
ENG-2393-fix-integration-page-to-only-show-for-current-monitor-for-okta
Jan 27, 2026
Merged

[ENG-2393] Use discovery_monitor endpoint for Okta monitor filtering#7256
dsill-ethyca merged 5 commits intomainfrom
ENG-2393-fix-integration-page-to-only-show-for-current-monitor-for-okta

Conversation

@dsill-ethyca
Copy link
Copy Markdown
Contributor

@dsill-ethyca dsill-ethyca commented Jan 27, 2026

Ticket ENG-2393

Description Of Changes

Updated the integrations page to use the /discovery-monitor endpoint instead of the deprecated /identity-provider-monitors endpoint when displaying monitors for Okta integrations. The /discovery-monitor endpoint supports filtering by connection_config_key, which ensures only monitors associated with the selected integration are displayed.

Code Changes

  • Removed conditional logic that used useGetIdentityProviderMonitorsQuery for Okta integrations
  • Now uses useGetMonitorsByIntegrationQuery for all monitor types, including Okta
  • Removed unused import for useGetIdentityProviderMonitorsQuery

Steps to Confirm

  1. Navigate to an Okta integration page at /integrations/okta_integration#data-discovery
  2. Verify that only monitors associated with that specific Okta integration are displayed
  3. Verify that monitors from other integrations are not shown
  4. Confirm that pagination and other table functionality still works correctly

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 27, 2026 6:12pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 27, 2026 6:12pm

Request Review

@dsill-ethyca dsill-ethyca marked this pull request as ready for review January 27, 2026 17:43
@dsill-ethyca dsill-ethyca requested a review from a team as a code owner January 27, 2026 17:43
@dsill-ethyca dsill-ethyca requested review from speaker-ender and removed request for a team January 27, 2026 17:43
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 27, 2026

Greptile Overview

Greptile Summary

This PR refactors the integrations page to use a unified endpoint for fetching monitors across all integration types, including Okta. Previously, Okta integrations used a separate deprecated /identity-provider-monitors endpoint, which caused monitors from all Okta integrations to be displayed together. The change simplifies the code by removing conditional logic and ensures proper filtering of monitors by connection_config_key.

Changes:

  • Removed useGetIdentityProviderMonitorsQuery import and usage
  • Removed isOktaIntegration conditional that determined which query to use
  • Now uses useGetMonitorsByIntegrationQuery for all integration types
  • Simplified code by eliminating separate regularMonitorsQuery and oktaMonitorsQuery variables

The refactoring is clean and reduces technical debt by removing the special-case handling for Okta.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward and well-scoped: removing deprecated endpoint usage and consolidating to a single endpoint that supports the same filtering capability. The code simplification reduces complexity and potential bugs. No logic errors or breaking changes detected.
  • No files require special attention

Important Files Changed

Filename Overview
changelog/ENG-2393.yaml Added changelog entry describing the bug fix for Okta integration monitor filtering
clients/admin-ui/src/features/integrations/hooks/useMonitorConfigTable.tsx Removed conditional logic for Okta integrations, now uses single endpoint (useGetMonitorsByIntegrationQuery) for all monitor types

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

@dsill-ethyca dsill-ethyca added this pull request to the merge queue Jan 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2026
@dsill-ethyca dsill-ethyca added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit e1c3217 Jan 27, 2026
46 checks passed
@dsill-ethyca dsill-ethyca deleted the ENG-2393-fix-integration-page-to-only-show-for-current-monitor-for-okta branch January 27, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants