feat: data steward filtering [ENG-2074]#7254
Merged
speaker-ender merged 2 commits intomainfrom Jan 28, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Greptile OverviewGreptile SummaryThis PR adds data steward filtering to the monitor list screen, allowing users to filter monitors by assigned stewards. The filter defaults to the current user and updates the URL state. Key Changes:
Issues Found:
Confidence Score: 3/5
Important Files Changed
|
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useSearchForm.ts
Show resolved
Hide resolved
...n-ui/src/features/data-discovery-and-detection/action-center/forms/MonitorListSearchForm.tsx
Show resolved
Hide resolved
|
|
||
| useEffect(() => { | ||
| resetPagination(); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Contributor
There was a problem hiding this comment.
Using JSON.stringify(requestData) in the dependency array can cause unnecessary re-renders if the object reference changes but the values remain the same. Consider using a more stable dependency or memoizing requestData.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResult.tsx
Show resolved
Hide resolved
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.tsx
Outdated
Show resolved
Hide resolved
69af2cc to
da08962
Compare
a7278a6 to
c040583
Compare
c040583 to
2cb51b0
Compare
chore: api update chore: updating api binding chore: type fixes chore: wip fixes fix: all the types feat: actually adding steward fix: correct types for table feat: default initial values chore: type and linting fixes chore: wip chore: just more work wip: i hate these form utilities wip: neeed better form handling chore: good enough chore: update api definition feat: adding stewards to monitor list items fix: missing type definition fix: type issue fix: pagination chore: adding changelog entry chore: ignore initial user if root
2cb51b0 to
1434cb7
Compare
jpople
approved these changes
Jan 28, 2026
Contributor
jpople
left a comment
There was a problem hiding this comment.
Tested locally, working as expected. Nice approach on the search hook.
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2074
Description Of Changes
Adding a filter to the monitor list that is linked to the url to filter by stewards assigned to a monitor.
Filter defaults to current user.
Code Changes
useSearchFilterhook to manage forms intended to filter search results on a screenMonitorListSearchFormcomponent to handle searching in the monitor screenSteps to Confirm
Data stewardfilter is visible and is pre-populated with your user value and the results are filtered by that valuePre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works