Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile OverviewGreptile SummaryThis PR adds SQLAlchemy deferred loading to prevent out-of-memory (OOM) errors when processing DSR tasks. The changes implement a new Key changes:
The implementation follows established patterns from Confidence Score: 4/5
Important Files Changed
|
galvana
approved these changes
Jan 26, 2026
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
JadeCara
added a commit
that referenced
this pull request
Jan 29, 2026
Co-authored-by: Jade Wibbels <jade@ethyca.com> Co-authored-by: Adrian Galvan <adrian@ethyca.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2126
Description Of Changes
🎯 Out of memory errors on workers when processing DSRs tasks
One area of opportunity identified was loading large data while querying tasks. This follows the pattern of defering loading of large columns for Privacy Request objects. This PR updates the following:
query_with_deferred_data()method for lazy loadingcached_erasure_results_by_collection_key()cached_consent_results_by_collection_key()Code Changes
src/fides/api/models/privacy_request/privacy_request.py- Updated to use query with deferred datasrc/fides/api/models/privacy_request/request_task.py- Addedquery_with_deferred_datasrc/fides/api/service/privacy_request/request_service.py- Updated to use query with deferred datasrc/fides/api/task/scheduler_utils.py- Updated to use query with deferred dataSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works