Skip to content

fix static checks#7247

Merged
johnewart merged 11 commits intomainfrom
erosselli/fix-static-checks
Jan 27, 2026
Merged

fix static checks#7247
johnewart merged 11 commits intomainfrom
erosselli/fix-static-checks

Conversation

@erosselli
Copy link
Copy Markdown
Contributor

Ticket []

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@erosselli erosselli requested a review from a team as a code owner January 26, 2026 14:32
@erosselli erosselli requested review from johnewart and removed request for a team January 26, 2026 14:32
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Jan 27, 2026 5:35pm
fides-privacy-center Ignored Ignored Jan 27, 2026 5:35pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 26, 2026

Greptile Overview

Greptile Summary

Applied automated code formatting fixes across 9 files to resolve static check violations. Changes include line length compliance, docstring formatting, import ordering, and trailing whitespace removal. All changes are purely cosmetic with no functional modifications to the codebase.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • All changes are purely cosmetic formatting fixes with no functional changes. The modifications comply with Python code style standards and improve code consistency without altering behavior.
  • No files require special attention

Important Files Changed

Filename Overview
src/fides/api/models/policy/conditional_dependency.py Removed unnecessary parentheses from query formatting
src/fides/api/task/conditional_dependencies/privacy_request/schemas.py Converted multi-line docstrings to single-line format
src/fides/api/task/manual/manual_task_conditional_evaluation.py Reformatted type annotation to comply with line length limits
src/fides/api/task/manual/manual_task_utils.py Reformatted query joins and list comprehension for line length compliance
tests/api/models/manual_task/test_manual_task_conditional_dependencies.py Fixed import order and reformatted function calls for line length compliance

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@adamsachs adamsachs mentioned this pull request Jan 26, 2026
18 tasks
Copy link
Copy Markdown
Collaborator

@johnewart johnewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 As long as the tests pass LGTM

@johnewart johnewart enabled auto-merge January 27, 2026 17:39
@johnewart johnewart added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit eb9dc89 Jan 27, 2026
53 of 55 checks passed
@johnewart johnewart deleted the erosselli/fix-static-checks branch January 27, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants