Updates to infrastructure monitor form#7240
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
…the-LLM-toggle-in-the-monitor-creation-modal
Greptile SummaryThis PR implements UI improvements for infrastructure monitor forms by addressing three key areas: hiding LLM classification options for infrastructure monitors (which don't use classification), ensuring sensitive multiline fields use password inputs instead of textareas, and updating terminology from "SSO" to the more accurate "identity provider." Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files Changed
|
clients/admin-ui/src/features/integrations/configure-monitor/ConfigureMonitorForm.tsx
Outdated
Show resolved
Hide resolved
| <InfoText> | ||
| <strong>Authentication:</strong> Okta integration uses OAuth2 Client | ||
| Credentials with private_key_jwt for secure authentication. You'll | ||
| need to create an API Services application in Okta and generate an RSA key | ||
| pair. | ||
| </InfoText> |
There was a problem hiding this comment.
@lucanovera this looks like a duplicate of the section above it. Did you mean to remove it at some point or maybe it was a merge conflict?
There was a problem hiding this comment.
I checked, they're both in use. I think we need a better description for the integration instead of just repeating the auth information. I'll create a followup.
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…the-LLM-toggle-in-the-monitor-creation-modal
…-modal' of github.com:ethyca/fides into ENG-2387-FE-Hide-the-LLM-toggle-in-the-monitor-creation-modal
|
@gilluminate thanks for the feedback, it's ready for a re-review when you can. |
Ticket ENG-2387 ENG-2394
Description Of Changes
Hides LLM toggle for infrastructure monitors. Updates text to say "Identity provider" instead of "SSO". Makes sensitive fields always use a password input, even when multiline.
Note: We don't have a component that supports password-like behavior and multiline like a Textarea. As a compromise for now, I think it's more important that we hide the sensitive information during creation, so an Input.Password will be used.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works