Skip to content

add policy name to conditions#7224

Merged
JadeCara merged 10 commits intomainfrom
add_policy_name_to_conditions
Jan 14, 2026
Merged

add policy name to conditions#7224
JadeCara merged 10 commits intomainfrom
add_policy_name_to_conditions

Conversation

@JadeCara
Copy link
Copy Markdown
Contributor

@JadeCara JadeCara commented Jan 14, 2026

Ticket ENG-2185

Description Of Changes

Updated the selector to use key with name label for policy conditions

Code Changes

  • clients/admin-ui/src/features/integrations/configure-tasks/utils.ts - update to use key
  • clients/admin-ui/src/features/integrations/configure-tasks/components/ConditionValueSelector.tsx - update selector

Steps to Confirm

  1. Verify that name any key show up under policy
Screenshot 2026-01-14 at 10 26 01 AM
  1. Create a consent manual task with condition and verify it works as expected
Screenshot 2026-01-14 at 10 26 19 AM

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 14, 2026 6:29pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 14, 2026 6:29pm

@JadeCara JadeCara marked this pull request as ready for review January 14, 2026 17:21
@JadeCara JadeCara requested a review from a team as a code owner January 14, 2026 17:21
@JadeCara JadeCara requested review from jpople and removed request for a team January 14, 2026 17:21
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 14, 2026

Greptile Summary

Added privacy_request.policy.name and privacy_request.policy.key to the allowlist of available condition fields for manual tasks.

  • Both fields are string types and will be handled correctly by the existing field type detection logic
  • Test coverage already exists for these fields in the test suite
  • These fields follow the same pattern as other policy fields (privacy_request.policy.id, privacy_request.policy.has_access_rule, etc.)

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change adds two new string fields (privacy_request.policy.name and privacy_request.policy.key) to an existing allowlist. The fields already have test coverage, follow the same pattern as existing policy fields, and will default to "string" type in getFieldType() which is correct for these fields
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/integrations/configure-tasks/utils.ts Added privacy_request.policy.name and privacy_request.policy.key to the allowed privacy request fields list for manual task conditions

@JadeCara JadeCara enabled auto-merge January 14, 2026 18:26
@JadeCara JadeCara added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit c52ae5b Jan 14, 2026
44 of 45 checks passed
@JadeCara JadeCara deleted the add_policy_name_to_conditions branch January 14, 2026 18:51
JadeCara added a commit that referenced this pull request Jan 14, 2026
Co-authored-by: Jade Wibbels <jade@ethyca.com>
Co-authored-by: Lucano Vera <lucanovera@live.com.ar>
mfbrown pushed a commit that referenced this pull request Jan 27, 2026
Co-authored-by: Jade Wibbels <jade@ethyca.com>
Co-authored-by: Lucano Vera <lucanovera@live.com.ar>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants