Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR modifies the package publishing workflow to allow alpha version tags (e.g., 2.10.0a0) to be published to PyPI as pre-releases instead of TestPyPI.
Changes Made:
- Added
steps.check-alpha-tag.outputs.match == 'false'to the TestPyPI upload condition (line 95) - Added
steps.check-alpha-tag.outputs.match == 'true'to the PyPI upload condition (line 103) - Updated comments to reflect that alpha tags now go to PyPI (lines 85-91, 93, 101)
Logic Verification:
The regex pattern ^refs/tags/[0-9]+\.[0-9]+\.[0-9]+a[0-9]+$ correctly matches PEP 440 alpha version format (e.g., 2.10.0a0, 2.10.0a1). The change is consistent with how the Docker publishing workflow already handles alpha tags (see .github/workflows/publish_docker.yaml lines 122-128).
Repository Dispatch:
The workflow correctly triggers a repository dispatch event to ethyca/fidesplus for both alpha and beta tags (lines 110-118), enabling integrated builds for feature tags.
Pre-existing Issue:
There is a pre-existing (not introduced by this PR) inconsistency in the Python setup step: the step name says "Setup Python 3.13.11" but the actual version configured is "3.11.11" (lines 16-19). While not related to this PR's changes, this should be corrected.
Confidence Score: 4/5
- This PR is safe to merge with minimal risk - it correctly implements the intended functionality
- Score of 4 reflects that the changes are straightforward, logically correct, and consistent with existing patterns in the codebase. The regex patterns match PEP 440 standards, and the implementation mirrors the Docker workflow's handling of alpha tags. The PR lacks a CHANGELOG entry as noted in the pre-merge checklist, and there's a pre-existing Python version mismatch that should be addressed separately. No logic errors or security issues were found in the actual changes.
- No files require special attention - the workflow logic is correct and well-commented
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/publish_package.yaml | 4/5 | Modified workflow to publish alpha tags to PyPI instead of TestPyPI. Logic is correct and consistent with Docker workflow patterns. Pre-existing Python version mismatch (line 16 vs 19) remains. |
Ticket []
Description Of Changes
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works