Skip to content

Allow publishing alpha tags to pypi#7209

Merged
erosselli merged 2 commits intomainfrom
erosselli/pre-release-changes
Jan 10, 2026
Merged

Allow publishing alpha tags to pypi#7209
erosselli merged 2 commits intomainfrom
erosselli/pre-release-changes

Conversation

@erosselli
Copy link
Copy Markdown
Contributor

Ticket []

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Jan 9, 2026 11:21pm
fides-privacy-center Ignored Ignored Jan 9, 2026 11:21pm

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR modifies the package publishing workflow to allow alpha version tags (e.g., 2.10.0a0) to be published to PyPI as pre-releases instead of TestPyPI.

Changes Made:

  • Added steps.check-alpha-tag.outputs.match == 'false' to the TestPyPI upload condition (line 95)
  • Added steps.check-alpha-tag.outputs.match == 'true' to the PyPI upload condition (line 103)
  • Updated comments to reflect that alpha tags now go to PyPI (lines 85-91, 93, 101)

Logic Verification:
The regex pattern ^refs/tags/[0-9]+\.[0-9]+\.[0-9]+a[0-9]+$ correctly matches PEP 440 alpha version format (e.g., 2.10.0a0, 2.10.0a1). The change is consistent with how the Docker publishing workflow already handles alpha tags (see .github/workflows/publish_docker.yaml lines 122-128).

Repository Dispatch:
The workflow correctly triggers a repository dispatch event to ethyca/fidesplus for both alpha and beta tags (lines 110-118), enabling integrated builds for feature tags.

Pre-existing Issue:
There is a pre-existing (not introduced by this PR) inconsistency in the Python setup step: the step name says "Setup Python 3.13.11" but the actual version configured is "3.11.11" (lines 16-19). While not related to this PR's changes, this should be corrected.

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - it correctly implements the intended functionality
  • Score of 4 reflects that the changes are straightforward, logically correct, and consistent with existing patterns in the codebase. The regex patterns match PEP 440 standards, and the implementation mirrors the Docker workflow's handling of alpha tags. The PR lacks a CHANGELOG entry as noted in the pre-merge checklist, and there's a pre-existing Python version mismatch that should be addressed separately. No logic errors or security issues were found in the actual changes.
  • No files require special attention - the workflow logic is correct and well-commented

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/publish_package.yaml 4/5 Modified workflow to publish alpha tags to PyPI instead of TestPyPI. Logic is correct and consistent with Docker workflow patterns. Pre-existing Python version mismatch (line 16 vs 19) remains.

@erosselli erosselli added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit f4bba85 Jan 10, 2026
51 checks passed
@erosselli erosselli deleted the erosselli/pre-release-changes branch January 10, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants