Skip to content

Add page-level errors across admin UI#7188

Merged
jpople merged 18 commits intomainfrom
jpople/eng-2244/add-page-errors
Jan 27, 2026
Merged

Add page-level errors across admin UI#7188
jpople merged 18 commits intomainfrom
jpople/eng-2244/add-page-errors

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Jan 7, 2026

Ticket ENG-2244

Description Of Changes

Adds error pages to many/most pages in the admin UI if the primary query fails.

Also some updates to error page component:

  • adds default error message
  • shows "reload" action by default
  • adds "show detail" for detailed error message

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner January 7, 2026 06:45
@jpople jpople requested review from gilluminate and removed request for a team January 7, 2026 06:45
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 27, 2026 5:35pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 27, 2026 5:35pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 7, 2026

Greptile Summary

This PR systematically adds error handling across the admin UI by implementing page-level error pages when primary queries fail. The changes follow a consistent pattern where pages check for errors from their data-fetching hooks and display the ErrorPage component with appropriate error messages.

Key improvements to ErrorPage component:

  • Added defaultMessage parameter with sensible default
  • Made showReload action enabled by default
  • Made actions prop optional
  • Added collapsible "Show details" section for error information
  • Added data-testid for testing

Implementation pattern:
Most pages follow the same clean pattern:

  1. Extract error from the data-fetching hook
  2. Early return with <ErrorPage> if error exists
  3. Provide contextual defaultMessage for the specific page

Properties page refactoring:
The properties page was refactored from a callback-based error handling pattern to match the standard pattern used throughout the codebase, improving consistency.

Test coverage:
Added cypress test for action center fields error handling to verify the error page displays correctly.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are well-structured and consistent across all files, following a standard error handling pattern. The refactoring improves code consistency (properties page), enhances UX with better error messaging, and includes test coverage. No logical issues or security concerns identified.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/common/errors/ErrorPage.tsx Enhanced error page component with default message, collapsible details, and automatic reload action
clients/admin-ui/src/pages/systems/index.tsx Added error handling for systems page using standard pattern
clients/admin-ui/src/pages/properties/index.tsx Refactored to use standard error handling pattern, extracting error from hook
clients/admin-ui/src/features/properties/PropertiesTable.tsx Removed callback-based error handling, now returns error from hook for consistency
clients/admin-ui/src/pages/integrations/[id].tsx Added error handling with custom action to return to integrations list
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx Added error handling for action center fields with appropriate error message

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

51 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of nit picks. Nice work!

@jpople jpople added this pull request to the merge queue Jan 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2026
@jpople jpople added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit 3eee156 Jan 27, 2026
45 of 46 checks passed
@jpople jpople deleted the jpople/eng-2244/add-page-errors branch January 27, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants