Skip to content

Fix taxonomy history endpoint URL#7181

Merged
jpople merged 1 commit intomainfrom
jpople/eng-2260/fix-taxonomy-history-url
Jan 5, 2026
Merged

Fix taxonomy history endpoint URL#7181
jpople merged 1 commit intomainfrom
jpople/eng-2260/fix-taxonomy-history-url

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Jan 5, 2026

Ticket ENG-2260

Description Of Changes

Fixes the taxonomy history view calling the wrong URL for the history (/taxonomies/..., not /plus/taxonomies/...)

Steps to Confirm

  1. Add a custom taxonomy
  2. Add some items to the taxonomy
  3. Click the root node of the taxonomy, then go to the "History" tab
  4. API should have called GET /plus/taxonomy/... and should see history entries

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner January 5, 2026 19:36
@jpople jpople requested review from gilluminate and removed request for a team January 5, 2026 19:36
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 5, 2026 7:38pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 5, 2026 7:38pm

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 5, 2026

Greptile Summary

This PR fixes a URL routing issue for the taxonomy history endpoint. The endpoint was incorrectly calling /taxonomies/{fides_key}/history when it should have been calling /plus/taxonomies/{fides_key}/history to access the Fides Plus taxonomy history feature.

  • Updated getTaxonomyHistory query URL to include the /plus/ prefix (line 131)

The fix is minimal, focused, and correctly addresses the routing issue described in the PR description.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • This is a simple, one-line URL fix that corrects an endpoint path. The change is straightforward, well-documented in the PR description, and only affects the taxonomy history feature. No logic changes, no security implications, and the fix aligns perfectly with the stated purpose.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/taxonomy/taxonomy.slice.ts Fixed taxonomy history endpoint URL by adding /plus/ prefix to correctly route to Plus API endpoint

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 5, 2026

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

@jpople jpople enabled auto-merge January 5, 2026 19:42
@jpople jpople added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit fcfedf0 Jan 5, 2026
48 checks passed
@jpople jpople deleted the jpople/eng-2260/fix-taxonomy-history-url branch January 5, 2026 20:01
jpople added a commit that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants