Skip to content

Fix classify action being enabled for muted resources#7180

Merged
gilluminate merged 1 commit intomainfrom
gill/ENG-2075/ignore-at-the-tree-level
Jan 5, 2026
Merged

Fix classify action being enabled for muted resources#7180
gilluminate merged 1 commit intomainfrom
gill/ENG-2075/ignore-at-the-tree-level

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate commented Jan 5, 2026

Ticket ENG-2075

Description Of Changes

Fixed a bug where the classify action was incorrectly enabled for muted/ignored resources in the schema explorer tree. Muted resources should not be classifiable since they are intentionally ignored.

Code Changes

  • Updated classify action disabled logic to also check if node is muted
  • Changed condition from simple node.classifyable to node.classifyable && node.diffStatus !== DiffStatus.MUTED

Steps to Confirm

  1. Navigate to Action Center and open a monitor with resources
  2. Ignore a database/schema/table node in the tree
  3. Right-click the ignored node and verify "Classify" action is disabled
  4. Multi-select ignored nodes and verify "Classify" is disabled in footer dropdown
  5. Restore the node and verify "Classify" becomes enabled again

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 5, 2026 7:31pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 5, 2026 7:31pm

@gilluminate gilluminate requested a review from vcruces January 5, 2026 19:40
@gilluminate gilluminate marked this pull request as ready for review January 5, 2026 19:40
@gilluminate gilluminate requested a review from a team as a code owner January 5, 2026 19:40
@gilluminate gilluminate requested review from jpople and removed request for a team and jpople January 5, 2026 19:40
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 5, 2026

Greptile Summary

Fixed a bug where the classify action was incorrectly enabled for muted/ignored resources in the schema explorer tree. The fix adds a check to ensure that the classify action is only enabled for nodes that are both classifyable and not muted (node.diffStatus !== DiffStatus.MUTED).

  • Updated classify action disabled logic to also check if node is muted
  • Change is consistent with existing patterns for MUTE and UN_MUTE actions in the same code block

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, focused bug fix that adds a single condition check to existing logic. The fix follows the established pattern already used for MUTE and UN_MUTE actions in the same code block, making it consistent with the codebase. The change is well-scoped and addresses a specific bug without introducing side effects.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx Fixed classify action being incorrectly enabled for muted resources by adding node.diffStatus !== DiffStatus.MUTED check

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 5, 2026

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

Copy link
Copy Markdown
Contributor

@vcruces vcruces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean and simple, thanks for fixing this so quickly!

@gilluminate gilluminate added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit bdac36f Jan 5, 2026
48 checks passed
@gilluminate gilluminate deleted the gill/ENG-2075/ignore-at-the-tree-level branch January 5, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants